Re: Simplify redability of some tests for toast_tuple_target in strings.sql

2019-04-03 Thread Michael Paquier
On Wed, Apr 03, 2019 at 09:38:57AM +, Daniel Gustafsson wrote: > +1, that's much more readable. Thanks! Thanks for the lookup, done. -- Michael signature.asc Description: PGP signature

Re: Simplify redability of some tests for toast_tuple_target in strings.sql

2019-04-03 Thread Daniel Gustafsson
On Wednesday, April 3, 2019 8:59 AM, Michael Paquier wrote: > Hi all, > > Some tests for toast_tuple_target introduced by c251336 check if a > toast relation is empty or not using that: > +select 0 = pg_relation_size('pg_toast.pg_toast_'||(select oid from > pg_class where relname = > 'toasttest'

Simplify redability of some tests for toast_tuple_target in strings.sql

2019-04-03 Thread Michael Paquier
Hi all, Some tests for toast_tuple_target introduced by c251336 check if a toast relation is empty or not using that: +select 0 = pg_relation_size('pg_toast.pg_toast_'||(select oid from pg_class where relname = 'toasttest'))/current_setting('block_size')::integer as blocks; This is overcomplicat