On Tue, Nov 21, 2023 at 3:57 PM Michael Paquier wrote:
>
> On Mon, Nov 20, 2023 at 05:07:38PM +0900, Michael Paquier wrote:
> > Good idea. What you are suggesting here improves the readability of
> > this code, so +1.
>
> And applied this one, thanks!
Thanks for pushing.
==
Kind Regards,
Pe
On Mon, Nov 20, 2023 at 05:07:38PM +0900, Michael Paquier wrote:
> Good idea. What you are suggesting here improves the readability of
> this code, so +1.
And applied this one, thanks!
--
Michael
signature.asc
Description: PGP signature
On Mon, Nov 20, 2023 at 06:01:42PM +1100, Peter Smith wrote:
> While reviewing another patch I was looking at the walsender's static
> function CreateReplicationSlot
>
> I found that the current logic seemed to have some unnecessary if/else
> checking which can be simplified.
Good idea. What you
Hi,
While reviewing another patch I was looking at the walsender's static
function CreateReplicationSlot
I found that the current logic seemed to have some unnecessary if/else
checking which can be simplified.
~~
To summarise:
CURRENT
if (cmd->kind == REPLICATION_KIND_PHYSICAL)
{
...
}
else
