On Mon, Jul 09, 2018 at 04:38:11PM +0300, Heikki Linnakangas wrote:
> Looks good to me. I'll mark this as "ready for committer".
Thanks Heikki for the review, I have committed both things after
splitting it into two commits for clarity, and fixing a comment as
fsync_pgdata also initiates a write-b
On 25/03/18 15:26, Michael Paquier wrote:
Hi all,
While looking at pg_rewind code, I have been surprised to find that the
final fsync done on the target's data folder is done using initdb -S via
a system() call. This is in my opinion overcomplicated because we have
a dedicated API in fe_utils a
On Sun, Mar 25, 2018 at 09:26:07PM +0900, Michael Paquier wrote:
> Both things are implemented as attached. I am of course not pushing for
> integrating that patch in v11 even if it is straight-forward, so I'll
> park it in the next future commit fest.
Patch has roted per the feedback of Mr Robot
Hi all,
While looking at pg_rewind code, I have been surprised to find that the
final fsync done on the target's data folder is done using initdb -S via
a system() call. This is in my opinion overcomplicated because we have
a dedicated API in fe_utils able to do a fsync on a data folder, called
f
