Re: Simplify create_merge_append_path a bit for clarity

2024-07-28 Thread Richard Guo
On Fri, Jul 26, 2024 at 1:28 PM Paul A Jungwirth wrote: > Is there a reason you don't want to remove the required_outer > parameter altogether? I guess because it is such a common pattern to > pass it? I think it's best to keep this parameter unchanged to maintain consistency with other functions

Re: Simplify create_merge_append_path a bit for clarity

2023-10-25 Thread Richard Guo
On Tue, Oct 24, 2023 at 6:00 PM Alena Rybakina wrote: > I agree with you, and we can indeed directly set the param_info value to > NULL, and there are enough comments here to explain. > > I didn't find anything else to add in your patch. Thanks for reviewing this patch! Thanks Richard

Re: Simplify create_merge_append_path a bit for clarity

2023-10-24 Thread Alena Rybakina
Hi! On 11.08.2023 05:31, Richard Guo wrote: As explained in the comments for generate_orderedappend_paths, we don't currently support parameterized MergeAppend paths, and it doesn't seem like going to change anytime soon.  Based on that,  we could simplify create_merge_append_path a bit, such as

Simplify create_merge_append_path a bit for clarity

2023-08-10 Thread Richard Guo
As explained in the comments for generate_orderedappend_paths, we don't currently support parameterized MergeAppend paths, and it doesn't seem like going to change anytime soon. Based on that, we could simplify create_merge_append_path a bit, such as set param_info to NULL directly rather than ca