Hi,
On Tue, 24 Jun 2025 at 18:12, Melanie Plageman
wrote:
>
> On Tue, Jun 24, 2025 at 9:17 AM Melanie Plageman
> wrote:
> >
> > On Tue, Jun 24, 2025 at 4:01 AM Nazir Bilal Yavuz
> > wrote:
> >
> > > I think we do not need to check visibility of the page here, as we
> > > already know that page
Thanks for the review!
On Tue, Jun 24, 2025 at 12:12 AM Masahiko Sawada wrote:
>
> On Tue, Jun 24, 2025 at 4:21 AM Melanie Plageman
> wrote:
>
> The flags is initialized as:
>
> uint8 flags = VISIBILITYMAP_ALL_VISIBLE;
>
> so the new if-condition is always true.
Yep, this was a mi
On Tue, Jun 24, 2025 at 9:17 AM Melanie Plageman
wrote:
>
> On Tue, Jun 24, 2025 at 4:01 AM Nazir Bilal Yavuz wrote:
>
> > I think we do not need to check visibility of the page here, as we
> > already know that page was not all-visible due to LP_DEAD items. We
> > can simply increment the vacrel
On Tue, Jun 24, 2025 at 4:21 AM Melanie Plageman
wrote:
>
> Hi,
>
> In dc6acfd910b8, I added some counters to track and log in
> autovacuum/vacuum output the number of pages newly set
> all-visible/frozen. Taking another look at the code recently, I
> realized the conditions for setting the counte
Hi,
In dc6acfd910b8, I added some counters to track and log in
autovacuum/vacuum output the number of pages newly set
all-visible/frozen. Taking another look at the code recently, I
realized the conditions for setting the counters could be simplified
because of what we know to be true about the st
