Re: Silly API for do_pg_start_backup()

2017-12-04 Thread Michael Paquier
On Tue, Dec 5, 2017 at 3:58 AM, Tom Lane wrote: > Barring objection I'll remove the tblspcdir parameter and have > do_pg_start_backup() open and close the directory immediately > around the loop where it's read, like every other case in the > backend. +1. Thanks for the change. What has been comm

Silly API for do_pg_start_backup()

2017-12-04 Thread Tom Lane
Why is it that do_pg_start_backup() expects its callers to pass in an open DIR pointer for the pg_tblspc directory, rather than doing the AllocateDir call for itself? This complicates the callers, provides no flexibility (since do_pg_start_backup() is hardwired to know that pg_tblspc is what it wa