Re: Show version of OpenSSL in ./configure output

2023-10-24 Thread Michael Paquier
On Mon, Oct 23, 2023 at 08:44:01PM -0400, Tom Lane wrote: > OK by me. Cool, done down to 16 as this depends on c8e4030d1bdd. -- Michael signature.asc Description: PGP signature

Re: Show version of OpenSSL in ./configure output

2023-10-23 Thread Tom Lane
Michael Paquier writes: > Please find attached a patch to move the version call close to the > existing PGAC_PATH_PROGS. And of course, I'd like to do a backpatch. > Is that OK? OK by me. regards, tom lane

Re: Show version of OpenSSL in ./configure output

2023-10-23 Thread Michael Paquier
On Mon, Oct 23, 2023 at 06:06:02PM +0200, Peter Eisentraut wrote: > On 23.10.23 16:26, Tom Lane wrote: >> Also, since "PGAC_PATH_PROGS(OPENSSL, openssl)" prints the full path to >> what it found, you can at least tell after the fact that you are being >> misled, because you can cross-check that pat

Re: Show version of OpenSSL in ./configure output

2023-10-23 Thread Daniel Gustafsson
> On 23 Oct 2023, at 18:06, Peter Eisentraut wrote: > > On 23.10.23 16:26, Tom Lane wrote: >> Also, since "PGAC_PATH_PROGS(OPENSSL, openssl)" prints the full path to what >> it found, you can at least tell after the fact that you are being misled, >> because you can cross-check that path agains

Re: Show version of OpenSSL in ./configure output

2023-10-23 Thread Peter Eisentraut
On 23.10.23 16:26, Tom Lane wrote: Also, since "PGAC_PATH_PROGS(OPENSSL, openssl)" prints the full path to what it found, you can at least tell after the fact that you are being misled, because you can cross-check that path against the -L switches being used for libraries. Yeah, that seems ok

Re: Show version of OpenSSL in ./configure output

2023-10-23 Thread Tom Lane
Daniel Gustafsson writes: > On 23 Oct 2023, at 08:22, Peter Eisentraut wrote: >> The problem is that the binary might not match the library, so this could be >> very misleading. Also, meson gets the version via pkg-config, so the result >> would also be inconsistent with meson. I am afraid th

Re: Show version of OpenSSL in ./configure output

2023-10-23 Thread Daniel Gustafsson
> On 23 Oct 2023, at 08:22, Peter Eisentraut wrote: > > On 23.10.23 02:26, Michael Paquier wrote: >> 5e4dacb9878c has reminded me that we don't show the version of OpenSSL >> in the output of ./configure. This would be useful to know when >> looking at issues within the buildfarm, and I've wante

Re: Show version of OpenSSL in ./configure output

2023-10-22 Thread Peter Eisentraut
On 23.10.23 02:26, Michael Paquier wrote: 5e4dacb9878c has reminded me that we don't show the version of OpenSSL in the output of ./configure. This would be useful to know when looking at issues within the buildfarm, and I've wanted that a few times. How about the attached to use the openssl co

Re: Show version of OpenSSL in ./configure output

2023-10-22 Thread Michael Paquier
On Sun, Oct 22, 2023 at 08:34:40PM -0400, Tom Lane wrote: > +1, I've wished for that too. It's not 100% clear that whatever > openssl is in your PATH matches the libraries we select, but this > will get it right in most cases and it seems like about the right > level of effort. Yes, I don't reall

Re: Show version of OpenSSL in ./configure output

2023-10-22 Thread Tom Lane
Michael Paquier writes: > 5e4dacb9878c has reminded me that we don't show the version of OpenSSL > in the output of ./configure. This would be useful to know when > looking at issues within the buildfarm, and I've wanted that a few > times. +1, I've wished for that too. It's not 100% clear that

Show version of OpenSSL in ./configure output

2023-10-22 Thread Michael Paquier
Hi all, 5e4dacb9878c has reminded me that we don't show the version of OpenSSL in the output of ./configure. This would be useful to know when looking at issues within the buildfarm, and I've wanted that a few times. How about the attached to use the openssl command, if available, to display thi