Re: Setting restrictedtoken in pg_regress

2023-07-06 Thread Daniel Gustafsson
> On 14 Jun 2023, at 13:02, Andrew Dunstan wrote: > On 2023-06-12 Mo 19:43, Nathan Bossart wrote: >> On Tue, Jun 13, 2023 at 08:29:19AM +0900, Michael Paquier wrote: >> >>> I am actually a bit confused with the return value of >>> CreateRestrictedProcess() on failures in restricted_token.c. Woul

Re: Setting restrictedtoken in pg_regress

2023-06-14 Thread Andrew Dunstan
On 2023-06-12 Mo 19:43, Nathan Bossart wrote: On Tue, Jun 13, 2023 at 08:29:19AM +0900, Michael Paquier wrote: I am actually a bit confused with the return value of CreateRestrictedProcess() on failures in restricted_token.c. Wouldn't it be cleaner to return INVALID_HANDLE_VALUE rather than 0

Re: Setting restrictedtoken in pg_regress

2023-06-12 Thread Nathan Bossart
On Tue, Jun 13, 2023 at 08:29:19AM +0900, Michael Paquier wrote: > I am actually a bit confused with the return value of > CreateRestrictedProcess() on failures in restricted_token.c. Wouldn't > it be cleaner to return INVALID_HANDLE_VALUE rather than 0 in these > cases? My suspicion is that this

Re: Setting restrictedtoken in pg_regress

2023-06-12 Thread Michael Paquier
On Mon, Jun 12, 2023 at 04:12:22PM -0700, Nathan Bossart wrote: > On Tue, Aug 30, 2022 at 03:02:54PM +0200, Daniel Gustafsson wrote: >> In pg_regress we set restrictedToken when calling CreateRestrictedProcess, >> but >> we never seem to use that anywhere. Not being well versed in Windows I might

Re: Setting restrictedtoken in pg_regress

2023-06-12 Thread Nathan Bossart
On Tue, Aug 30, 2022 at 03:02:54PM +0200, Daniel Gustafsson wrote: > In pg_regress we set restrictedToken when calling CreateRestrictedProcess, but > we never seem to use that anywhere. Not being well versed in Windows I might > be missing something, but is it needed or is it a copy/pasteo from fa

Setting restrictedtoken in pg_regress

2022-08-30 Thread Daniel Gustafsson
In pg_regress we set restrictedToken when calling CreateRestrictedProcess, but we never seem to use that anywhere. Not being well versed in Windows I might be missing something, but is it needed or is it a copy/pasteo from fa1e5afa8a2 which does that in restricted_token.c? If not needed, removing