Re: Server crash in pg_replication_slot_advance function

2018-02-19 Thread Alvaro Herrera
Petr Jelinek wrote: > > Attached patch proposes a required fix. > > > > Looks correct to me. Masahiko Sawada wrote: > The change looks good to me. Thank you. Thanks, pushed. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Tra

Re: Server crash in pg_replication_slot_advance function

2018-02-16 Thread Masahiko Sawada
On Fri, Feb 16, 2018 at 6:55 PM, amul sul wrote: > On Fri, Feb 16, 2018 at 3:06 PM, amul sul wrote: >> On Fri, Feb 16, 2018 at 1:44 PM, tushar >> wrote: >>> Hi, >> [] >>> postgres=# SELECT end_lsn FROM >>> pg_replication_slot_advance('regression_slot1', '0/271'); >>> server closed the c

Re: Server crash in pg_replication_slot_advance function

2018-02-16 Thread Petr Jelinek
On 16/02/18 10:55, amul sul wrote: > On Fri, Feb 16, 2018 at 3:06 PM, amul sul wrote: >> On Fri, Feb 16, 2018 at 1:44 PM, tushar >> wrote: >>> Hi, >> [] >>> postgres=# SELECT end_lsn FROM >>> pg_replication_slot_advance('regression_slot1', '0/271'); >>> server closed the connection unexp

Re: Server crash in pg_replication_slot_advance function

2018-02-16 Thread tushar
On 02/16/2018 03:25 PM, amul sul wrote: Attached patch proposes a required fix. Thanks, Issue seems to be fixed with this patch , now getting an expected error -ERROR:  cannot move slot to 0/290, minimum is 0/298 -- regards,tushar EnterpriseDB https://www.enterprisedb.com/ The Ent

Re: Server crash in pg_replication_slot_advance function

2018-02-16 Thread amul sul
On Fri, Feb 16, 2018 at 3:06 PM, amul sul wrote: > On Fri, Feb 16, 2018 at 1:44 PM, tushar wrote: >> Hi, > [] >> postgres=# SELECT end_lsn FROM >> pg_replication_slot_advance('regression_slot1', '0/271'); >> server closed the connection unexpectedly >> This probably means the server termi

Re: Server crash in pg_replication_slot_advance function

2018-02-16 Thread amul sul
On Fri, Feb 16, 2018 at 1:44 PM, tushar wrote: > Hi, [] > postgres=# SELECT end_lsn FROM > pg_replication_slot_advance('regression_slot1', '0/271'); > server closed the connection unexpectedly > This probably means the server terminated abnormally > before or while processing the request.

Server crash in pg_replication_slot_advance function

2018-02-16 Thread tushar
Hi, While playing around with newly implemented function 'pg_replication_slot_advance' , found a server crash . Please refer the testcase scenario - centos@centos-cpula bin]$ ./psql  postgres psql (11devel) Type "help" for help. postgres=#  SELECT * FROM pg_create_logical_replication_slot('