Re: SQLJSON: errmsg(" .. should ...") -> must

2025-01-21 Thread Amit Langote
On Tue, Jan 21, 2025 at 11:42 PM Alvaro Herrera wrote: > On 2025-Jan-13, Alvaro Herrera wrote: > > > There's a few recent SQL/JSON error messages in which we say something > > "should" be something else. We avoid this, so I think we shouldn't use > > it here either. > > Pushed. Sorry Alvaro for

Re: SQLJSON: errmsg(" .. should ...") -> must

2025-01-21 Thread Alvaro Herrera
On 2025-Jan-13, Alvaro Herrera wrote: > There's a few recent SQL/JSON error messages in which we say something > "should" be something else. We avoid this, so I think we shouldn't use > it here either. Pushed. -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/

SQLJSON: errmsg(" .. should ...") -> must

2025-01-13 Thread Alvaro Herrera
Hi There's a few recent SQL/JSON error messages in which we say something "should" be something else. We avoid this, so I think we shouldn't use it here either. (There's also wparser_def.c which uses "should" in that way, and I think it's there just because it's a dark unvisited corner that's be