Re: SIGSEGV, FPE fix in pg_controldata

2025-02-04 Thread Alexander Korotkov
On Tue, Feb 4, 2025 at 6:36 PM Ilyasov Ian wrote: > > Thank you for your answer, Alexander! > I like your patch and it looks similar to my first version of it before I > came up to the possible segment size problem. Ok. > >Also, I don't think we should change > segment size to uint32 as it's al

RE: SIGSEGV, FPE fix in pg_controldata

2025-02-04 Thread Ilyasov Ian
Thank you for your answer, Alexander! I like your patch and it looks similar to my first version of it before I came up to the possible segment size problem. >Also, I don't think we should change segment size to uint32 as it's already defined as int in awfully a lot of places I agree that changi

Re: SIGSEGV, FPE fix in pg_controldata

2025-02-03 Thread Alexander Korotkov
Hi Ian, On Thu, Dec 12, 2024 at 12:23 PM Ilyasov Ian wrote: > SIGSEGV was caused by two places in pg_controldata.c where there > is a work with localtime(&time_tmp));. So I added a check for not NULL. > > > > Where casting second operand in % (XLogSegmentsPerXLogId(wal_segsz_bytes)) to > un

SIGSEGV, FPE fix in pg_controldata

2024-12-12 Thread Ilyasov Ian
Hello, hackers! Recently I've faced an issue when playing with pg_controldata. I made some rubbish pg_control files and caught a SIGSEGV. Then I tried fuzzing REL_17_STABLE pg_controldata with AFL++ and got 7 crash cases. Also, it is not necessary to use fuzzing. You can simply generate any pg_co