Re: Running tests under valgrind is getting slower at an alarming pace

2021-10-08 Thread Andres Freund
On 2021-10-08 15:41:09 -0400, Andrew Dunstan wrote: > see > Thanks!

Re: Running tests under valgrind is getting slower at an alarming pace

2021-10-08 Thread Andrew Dunstan
On 10/6/21 10:03 PM, Andres Freund wrote: > Hi, > > On 2021-10-06 09:47:54 -0700, Andres Freund wrote: >> I'll also try to figure out print a bit more detail about timing for each tap >> test, looks like I need to figure out how to pass PROVE_TEST='--timer' >> through >> the buildfarm. Shouldn't

Re: Running tests under valgrind is getting slower at an alarming pace

2021-10-06 Thread Andres Freund
Hi, On 2021-10-06 09:47:54 -0700, Andres Freund wrote: > I'll also try to figure out print a bit more detail about timing for each tap > test, looks like I need to figure out how to pass PROVE_TEST='--timer' through > the buildfarm. Shouldn't be too hard. Turns out that the buildfarm already adds

Re: Running tests under valgrind is getting slower at an alarming pace

2021-10-06 Thread Andres Freund
Hi, On 2021-10-06 12:58:34 -0400, Tom Lane wrote: > Andres Freund writes: > > One thing I think would really help is having the total time for each run > > visible in an animals run history. That way we could pinpoint regressions > > reasonably efficiently, right now that's not easily possible wi

Re: Running tests under valgrind is getting slower at an alarming pace

2021-10-06 Thread Robert Haas
On Wed, Oct 6, 2021 at 12:47 PM Andres Freund wrote: > There's probably some of that. > > The fact that the tap test infrastructure does all communication with the > server via psql each only execute only a single query is a problem - > connection startup is expensive. Ageed. safe_psql() is a poo

Re: Running tests under valgrind is getting slower at an alarming pace

2021-10-06 Thread Tom Lane
Andres Freund writes: > One thing I think would really help is having the total time for each run > visible in an animals run history. That way we could pinpoint regressions > reasonably efficiently, right now that's not easily possible without writing > nontrivial queries to the buildfarm databas

Re: Running tests under valgrind is getting slower at an alarming pace

2021-10-06 Thread Andres Freund
Hi, On 2021-10-06 12:09:36 -0400, Robert Haas wrote: > Is the problem here that we're adding a lot of new new test cases? Or > is the problem that valgrind runs are getting slower for the same > number of test cases? I don't know precisely. It's probably a combination of several factors. I do thi

Re: Running tests under valgrind is getting slower at an alarming pace

2021-10-06 Thread Robert Haas
On Wed, Oct 6, 2021 at 1:57 AM Andres Freund wrote: > After a recent migration of the skink and a few other animals (sorry for the > false reports on BF, I forgot to adjust a path), I looked at the time it takes > to complete a valgrind run: > > 9.6: Consumed 4h 53min 18.518s CPU time > 10: Consum

Re: Running tests under valgrind is getting slower at an alarming pace

2021-10-06 Thread Tom Lane
Andres Freund writes: > After a recent migration of the skink and a few other animals (sorry for the > false reports on BF, I forgot to adjust a path), I looked at the time it takes > to complete a valgrind run: > 9.6: Consumed 4h 53min 18.518s CPU time > 10: Consumed 5h 32min 50.839s CPU time >

Running tests under valgrind is getting slower at an alarming pace

2021-10-05 Thread Andres Freund
Hi, After a recent migration of the skink and a few other animals (sorry for the false reports on BF, I forgot to adjust a path), I looked at the time it takes to complete a valgrind run: 9.6: Consumed 4h 53min 18.518s CPU time 10: Consumed 5h 32min 50.839s CPU time 11: Consumed 7h 7min 17.455s