Dear Michael,
> I've looked at that again and let this as-is, then applied all this
> cleanup.
I missed your e-mail but it's ok to keep the output style for two_phase.
Thanks a lot for working on it!
Best regards,
Hayato Kuroda
FUJITSU LIMITED
On Sat, Nov 30, 2024 at 12:54:19PM +0900, Michael Paquier wrote:
> - if (strcmp(subinfo->subtwophasestate, two_phase_disabled) != 0)
> + if (subinfo->subtwophasestate != LOGICALREP_TWOPHASE_STATE_DISABLED)
> appendPQExpBufferStr(query, ", two_phase = on");
>
> I'm not feeling strongly
On Fri, Nov 29, 2024 at 05:42:13AM +, Hayato Kuroda (Fujitsu) wrote:
> It was not good to follow existing codes without confirmation :-(.
No problem.
> I grepped files in bin/ and could not find lines which includes
> catalog/pg_xxx.h files.
> (One exception is pg_control.h. It is not a cata
Dear Michael,
Thanks for working on this.
It was not good to follow existing codes without confirmation :-(.
I grepped files in bin/ and could not find lines which includes
catalog/pg_xxx.h files.
(One exception is pg_control.h. It is not a catalog-header but has the same
prefix.)
The patch bas
Hi all,
While looking at some of the code related to subscriptions in psql,
coming down to make LOGICALREP_STREAM_* available for client code,
I've also noticed quite a few inconsistencies and mistakes with how
pg_subscription is handled in pg_dump, that have accumulated over the
years as of what
