Re: Retiring is_pushed_down

2025-01-14 Thread Richard Guo
On Fri, Sep 27, 2024 at 5:06 AM Tom Lane wrote: > So I'm worried that the point about lateral refs is still a problem > in your version. To be clear, the hazard is that if a WHERE clause > ends up getting placed at an outer join that's higher than any of > the OJs specifically listed in its requi

Re: Retiring is_pushed_down

2024-09-26 Thread Tom Lane
Richard Guo writes: > When forming an outer join's joinrel, we have the is_pushed_down flag in > RestrictInfo nodes to distinguish those quals that are in that join's > JOIN/ON condition from those that were pushed down to the joinrel and > thus act as filter quals. Since now we have the outer-jo

Re: Retiring is_pushed_down

2024-09-10 Thread Rafia Sabih
I see following issue with the latest patch, relnode.c:2122:32: error: use of undeclared identifier 'ojrelids' RINFO_IS_PUSHED_DOWN(rinfo, ojrelids, joinrel->relids)) On Thu, 18 Apr 2024 at 09:34, Richard Guo wrote: > Here is another rebase over 3af7040985. Nothing else

Re: Retiring is_pushed_down

2024-04-18 Thread Richard Guo
Here is another rebase over 3af7040985. Nothing else has changed. Thanks Richard v4-0001-Retiring-is_pushed_down.patch Description: Binary data

Re: Retiring is_pushed_down

2024-01-29 Thread Richard Guo
On Sun, Jan 21, 2024 at 8:37 PM vignesh C wrote: > I'm seeing that there has been no activity in this thread for nearly 6 > months, I'm planning to close this in the current commitfest unless > someone is planning to take it forward. It can be opened again when > there is more interest. I'm pla

Re: Retiring is_pushed_down

2024-01-21 Thread vignesh C
On Thu, 27 Jul 2023 at 08:25, Richard Guo wrote: > > > On Tue, Jul 25, 2023 at 3:39 PM Richard Guo wrote: >> >> * This patch calculates the outer join relids that are being formed >> generally in this way: >> >> bms_difference(joinrelids, bms_union(outerrelids, innerrelids)) >> >> Of course t

Re: Retiring is_pushed_down

2023-07-26 Thread Richard Guo
On Tue, Jul 25, 2023 at 3:39 PM Richard Guo wrote: > * This patch calculates the outer join relids that are being formed > generally in this way: > > bms_difference(joinrelids, bms_union(outerrelids, innerrelids)) > > Of course this can only be used after the outer join relids has been > adde

Retiring is_pushed_down

2023-07-25 Thread Richard Guo
When forming an outer join's joinrel, we have the is_pushed_down flag in RestrictInfo nodes to distinguish those quals that are in that join's JOIN/ON condition from those that were pushed down to the joinrel and thus act as filter quals. Since now we have the outer-join-aware-Var infrastructure,