Re: Report search_path value back to the client.

2024-08-19 Thread Tom Lane
Tomas Vondra writes: > On 8/19/24 18:19, Tom Lane wrote: >> I recall there being two places, so that's probably the extent of it >> ... yeah, the last similar patch was d16f8c8e4, and that's what >> it did. > Thanks, updated in a similar way. LGTM, thanks. regards, tom l

Re: Report search_path value back to the client.

2024-08-19 Thread Tomas Vondra
On 8/19/24 18:19, Tom Lane wrote: > Tomas Vondra writes: >> I see there are two places in libpq.sgml and protocol.sgml that should >> list search_path - will fix. I haven't found any other place in the docs >> that would need an update, or did I miss something? > > I recall there being two places

Re: Report search_path value back to the client.

2024-08-19 Thread Tom Lane
Tomas Vondra writes: > I see there are two places in libpq.sgml and protocol.sgml that should > list search_path - will fix. I haven't found any other place in the docs > that would need an update, or did I miss something? I recall there being two places, so that's probably the extent of it ... y

Re: Report search_path value back to the client.

2024-08-19 Thread Tomas Vondra
On 8/19/24 18:02, Tom Lane wrote: > Tomas Vondra writes: >> On 8/14/24 18:30, Jelte Fennema-Nio wrote: >>> Looks good to me. > >> Pushed, after rewording the commit message a bit. > > This patch does not appear to have updated any of the relevant > documentation. > Oh, I haven't realized we ex

Re: Report search_path value back to the client.

2024-08-19 Thread Tom Lane
Tomas Vondra writes: > On 8/14/24 18:30, Jelte Fennema-Nio wrote: >> Looks good to me. > Pushed, after rewording the commit message a bit. This patch does not appear to have updated any of the relevant documentation. regards, tom lane

Re: Report search_path value back to the client.

2024-08-19 Thread Tomas Vondra
On 8/14/24 18:30, Jelte Fennema-Nio wrote: > On Wed, 14 Aug 2024 at 18:22, Tomas Vondra wrote: >> Here's the patch with a somewhat expanded / improved commit message. >> Jelte, can you take a look there's no silly mistake? > > Looks good to me. Pushed, after rewording the commit message a bit.

Re: Report search_path value back to the client.

2024-08-14 Thread Jelte Fennema-Nio
On Wed, 14 Aug 2024 at 18:22, Tomas Vondra wrote: > Here's the patch with a somewhat expanded / improved commit message. > Jelte, can you take a look there's no silly mistake? Looks good to me.

Re: Report search_path value back to the client.

2024-08-14 Thread Tomas Vondra
Here's the patch with a somewhat expanded / improved commit message. Jelte, can you take a look there's no silly mistake? As mentioned previously, I plan to push this, so that if the protocol improvements from [1] don't land in PG18 we have at least something. I did take a brief look at the other

Re: Report search_path value back to the client.

2024-07-20 Thread Tomas Vondra
On 7/20/24 14:09, Jelte Fennema-Nio wrote: > On Fri, 19 Jul 2024 at 21:48, Tomas Vondra > wrote: >> >> >> >> On 7/19/24 17:16, Jelte Fennema-Nio wrote: >>> That's been moving forward, even relatively fast imho for the >>> size/impact of that patchset. But those changes are much less >>> straight-f

Re: Report search_path value back to the client.

2024-07-20 Thread Jelte Fennema-Nio
On Fri, 19 Jul 2024 at 21:48, Tomas Vondra wrote: > > > > On 7/19/24 17:16, Jelte Fennema-Nio wrote: > > That's been moving forward, even relatively fast imho for the > > size/impact of that patchset. But those changes are much less > > straight-forward than this patch. And while I hope that they

Re: Report search_path value back to the client.

2024-07-19 Thread Tomas Vondra
On 7/19/24 17:16, Jelte Fennema-Nio wrote: > On Thu, 18 Jul 2024 at 22:47, Tomas Vondra > wrote: >> That being said, it this makes using pgbouncer easier (or even possible >> in some applications where it currently does not work), I'd vote to get >> this committed. > > It definitely is a pain

Re: Report search_path value back to the client.

2024-07-19 Thread Jelte Fennema-Nio
On Thu, 18 Jul 2024 at 22:47, Tomas Vondra wrote: > That being said, it this makes using pgbouncer easier (or even possible > in some applications where it currently does not work), I'd vote to get > this committed. It definitely is a pain point for some setups. A speaker brought it up at FOSDEM

Re: Report search_path value back to the client.

2024-07-18 Thread Tomas Vondra
On 11/3/23 10:06, Jelte Fennema-Nio wrote: > I wanted to revive this thread, since it's by far one of the most > common foot guns that people run into with PgBouncer. Almost all > session level SET commands leak across transactions, but SET > search_path is by far the one with the biggest impact wh

Re: Report search_path value back to the client.

2023-11-03 Thread Jelte Fennema-Nio
For completeness attached is a tiny patch implementing this, so this thread can be added to the commit fest. v1-0001-Mark-search_path-as-GUC_REPORT.patch Description: Binary data

Re: Report search_path value back to the client.

2023-11-03 Thread Jelte Fennema-Nio
I wanted to revive this thread, since it's by far one of the most common foot guns that people run into with PgBouncer. Almost all session level SET commands leak across transactions, but SET search_path is by far the one with the biggest impact when it is not the setting that you expect. As well a