Re: Report roles in pg_upgrade pg_ prefix check

2022-12-02 Thread Daniel Gustafsson
> On 29 Nov 2022, at 00:24, Michael Paquier wrote: > > On Mon, Nov 28, 2022 at 09:58:46AM +0100, Daniel Gustafsson wrote: >> We are a bit inconsistent in how much details we include in the report >> textfiles, so could do that without breaking any consistency in reporting. >> Looking at other che

Re: Report roles in pg_upgrade pg_ prefix check

2022-11-28 Thread Michael Paquier
On Mon, Nov 28, 2022 at 09:58:46AM +0100, Daniel Gustafsson wrote: > We are a bit inconsistent in how much details we include in the report > textfiles, so could do that without breaking any consistency in reporting. > Looking at other checks, the below format would match what we already do > fair

Re: Report roles in pg_upgrade pg_ prefix check

2022-11-28 Thread Daniel Gustafsson
> On 28 Nov 2022, at 02:18, Michael Paquier wrote: > > On Thu, Nov 24, 2022 at 12:31:09PM +0100, Daniel Gustafsson wrote: >> Looking at a recent pg_upgrade thread I happened to notice that the check for >> roles with a pg_ prefix only reports the error, not the roles it found. >> Other >> simil

Re: Report roles in pg_upgrade pg_ prefix check

2022-11-27 Thread Michael Paquier
On Thu, Nov 24, 2022 at 12:31:09PM +0100, Daniel Gustafsson wrote: > Looking at a recent pg_upgrade thread I happened to notice that the check for > roles with a pg_ prefix only reports the error, not the roles it found. Other > similar checks where the user is expected to alter the old cluster ty

Re: Report roles in pg_upgrade pg_ prefix check

2022-11-25 Thread Bruce Momjian
On Thu, Nov 24, 2022 at 12:31:09PM +0100, Daniel Gustafsson wrote: > Looking at a recent pg_upgrade thread I happened to notice that the check for > roles with a pg_ prefix only reports the error, not the roles it found. Other > similar checks where the user is expected to alter the old cluster ty

Report roles in pg_upgrade pg_ prefix check

2022-11-24 Thread Daniel Gustafsson
Looking at a recent pg_upgrade thread I happened to notice that the check for roles with a pg_ prefix only reports the error, not the roles it found. Other similar checks where the user is expected to alter the old cluster typically reports the found objects in a textfile. The attached adds repor