Re: Replace l337sp34k in comments.

On 8/1/21 5:10 PM, Andres Freund wrote: > Hi, > > On 2021-07-31 12:15:34 +0300, Peter Geoghegan wrote: >> On Sat, Jul 31, 2021 at 11:22 AM Andrey Borodin wrote: >>> FWIW, my 2 cents. >>> I do not see much difference between up2date, up-to-date, up to date, >>> current, recent, actual, last, new

Re: Replace l337sp34k in comments.

Hi, On 2021-07-31 12:15:34 +0300, Peter Geoghegan wrote: > On Sat, Jul 31, 2021 at 11:22 AM Andrey Borodin wrote: > > FWIW, my 2 cents. > > I do not see much difference between up2date, up-to-date, up to date, > > current, recent, actual, last, newest, correct, fresh etc. > > +1. > To me it se

Re: Replace l337sp34k in comments.

On Saturday, July 31, 2021, Peter Geoghegan wrote: > On Sat, Jul 31, 2021 at 11:22 AM Andrey Borodin > wrote: > > FWIW, my 2 cents. > > I do not see much difference between up2date, up-to-date, up to date, > current, recent, actual, last, newest, correct, fresh etc. > > +1. > > To me it seems no

Re: Replace l337sp34k in comments.

On Sat, Jul 31, 2021 at 11:22 AM Andrey Borodin wrote: > FWIW, my 2 cents. > I do not see much difference between up2date, up-to-date, up to date, > current, recent, actual, last, newest, correct, fresh etc. +1. To me it seems normal to debate wording/terminology with new code comments, but tha

Re: Replace l337sp34k in comments.

> 28 июля 2021 г., в 04:39, Peter Smith написал(а): > > IMO the PG code comments are not an appropriate place for leetspeak > creativity. > > PSA a patch to replace a few examples that I recently noticed. > > "up2date" --> "up-to-date" FWIW, my 2 cents. I do not see much difference between

Re: Replace l337sp34k in comments.

On 30/07/21 8:05 pm, Geoff Winkless wrote: On Thu, 29 Jul 2021 at 22:46, Gavin Flower wrote: Though in code, possibly it would be better to just use 'up-to-date' in code for consistency and to make the it easier to grep? If it's causing an issue, perhaps using a less syntactically problematic

Re: Replace l337sp34k in comments.

On Thu, 29 Jul 2021 at 22:46, Gavin Flower wrote: > Though in code, possibly it would be better to just use 'up-to-date' in > code for consistency and to make the it easier to grep? If it's causing an issue, perhaps using a less syntactically problematic synonym like "current" might be better? :

Re: Replace l337sp34k in comments.

On Fri, Jul 30, 2021 at 09:46:59AM +1200, Gavin Flower wrote: > That 'feels' right to me. > > Though in code, possibly it would be better to just use 'up-to-date' in code > for consistency and to make the it easier to grep? The change in llvmjit_expr.c may not look like an adjective though, which

Re: Replace l337sp34k in comments.

On 30/07/21 12:51 am, Geoff Winkless wrote: On Thu, 29 Jul 2021 at 11:22, Andrew Dunstan > wrote: Personally, I would have written this as just "up to date", I don't think the hyphens are required. FWIW Mirriam-Webster and the CED suggest "up-to-date" when be

Re: Replace l337sp34k in comments.

On 7/29/21 8:51 AM, Geoff Winkless wrote: > On Thu, 29 Jul 2021 at 11:22, Andrew Dunstan > wrote: > > Personally, I would have written this as just "up to date", I don't > think the hyphens are required. > >   > FWIW Mirriam-Webster and the CED suggest "up-to-

Re: Replace l337sp34k in comments.

On Thu, 29 Jul 2021 at 11:22, Andrew Dunstan wrote: > Personally, I would have written this as just "up to date", I don't > think the hyphens are required. > FWIW Mirriam-Webster and the CED suggest "up-to-date" when before a noun, so the changes should be "up-to-date answer" but "are up to date

Re: Replace l337sp34k in comments.

On 7/27/21 7:39 PM, Peter Smith wrote: > IMO the PG code comments are not an appropriate place for leetspeak > creativity. > > PSA a patch to replace a few examples that I recently noticed. > > "up2date" --> "up-to-date" > Personally, I would have written this as just "up to date", I don't thin

Re: Replace l337sp34k in comments.

On Wed, Jul 28, 2021 at 11:32 AM Michael Paquier wrote: > > On Wed, Jul 28, 2021 at 09:39:02AM +1000, Peter Smith wrote: > > IMO the PG code comments are not an appropriate place for leetspeak > > creativity. > > > > PSA a patch to replace a few examples that I recently noticed. > > > > "up2date"

Re: Replace l337sp34k in comments.

On Wed, Jul 28, 2021 at 09:39:02AM +1000, Peter Smith wrote: > IMO the PG code comments are not an appropriate place for leetspeak > creativity. > > PSA a patch to replace a few examples that I recently noticed. > > "up2date" --> "up-to-date" Agreed that this is a bit cleaner to read, so done.

Replace l337sp34k in comments.

IMO the PG code comments are not an appropriate place for leetspeak creativity. PSA a patch to replace a few examples that I recently noticed. "up2date" --> "up-to-date" -- Kind Regards, Peter Smith. Fujitsu Australia v1-0001-Replace-leetspeak-comments-with-English.patch Description: Binar