Re: Reorder connection markers in libpq TAP tests

2023-04-21 Thread Daniel Gustafsson
> On 21 Apr 2023, at 08:38, Gurjeet Singh wrote: > > On Thu, Apr 20, 2023 at 11:00 PM Gurjeet Singh wrote: >> >> Commit 7f5b198 introduced TAP tests that use string literals to mark >> the presence of a query in server logs. For no explicable reason, the >> tests with the marker 'connect2' occu

Re: Reorder connection markers in libpq TAP tests

2023-04-21 Thread Jelte Fennema
LGTM I guess this was an unintended leftover from me reordering the tests a bit in the final stages of getting these patches in. On Fri, 21 Apr 2023 at 08:38, Gurjeet Singh wrote: > On Thu, Apr 20, 2023 at 11:00 PM Gurjeet Singh wrote: > > > > Commit 7f5b198 introduced TAP tests that use string

Re: Reorder connection markers in libpq TAP tests

2023-04-20 Thread Gurjeet Singh
On Thu, Apr 20, 2023 at 11:00 PM Gurjeet Singh wrote: > > Commit 7f5b198 introduced TAP tests that use string literals to mark > the presence of a query in server logs. For no explicable reason, the > tests with the marker 'connect2' occur before the tests that use > 'connect1' marker. > > The att

Reorder connection markers in libpq TAP tests

2023-04-20 Thread Gurjeet Singh
Commit 7f5b198 introduced TAP tests that use string literals to mark the presence of a query in server logs. For no explicable reason, the tests with the marker 'connect2' occur before the tests that use 'connect1' marker. The attached patch swaps the connection marker strings so that a reader doe