Re: Rename functions to alloc/free things in reorderbuffer.c

2025-03-12 Thread Heikki Linnakangas
On 12/03/2025 21:31, Tom Lane wrote: Heikki Linnakangas writes: ReorderBufferGetRelids allocates an array with MemoryContextAlloc, and ReorderBufferReturnRelids just calls pfree. The pools are long gone, and now the naming looks weird. Attached patch renames those functions and other such fu

Re: Rename functions to alloc/free things in reorderbuffer.c

2025-03-12 Thread Tom Lane
Heikki Linnakangas writes: > ReorderBufferGetRelids allocates an array with MemoryContextAlloc, and > ReorderBufferReturnRelids just calls pfree. The pools are long gone, and > now the naming looks weird. > Attached patch renames those functions and other such functions to use > the terms Allo

Rename functions to alloc/free things in reorderbuffer.c

2025-03-12 Thread Heikki Linnakangas
I noticed some weird naming conventions in reorderbuffer.c which are leftovers from a long time ago when reorderbuffer.c maintained its own small memory pools to reduce palloc/pfree overhead. For example: extern Oid *ReorderBufferGetRelids(ReorderBuffer *rb, int nrelids); extern void ReorderBuf