On Thu, Aug 29, 2024 at 09:28:49AM -0500, Nathan Bossart wrote:
> On Thu, Aug 29, 2024 at 02:11:22PM +0900, Michael Paquier wrote:
> > Okay, here is a v2 of the patch using this name for the function.
>
> LGTM
Thanks, applied that, after one tweak for the #define name.
--
Michael
signature.asc
On Thu, Aug 29, 2024 at 02:11:22PM +0900, Michael Paquier wrote:
> Okay, here is a v2 of the patch using this name for the function.
LGTM
--
nathan
On Wed, Aug 28, 2024 at 08:28:03PM -0500, Nathan Bossart wrote:
> On Thu, Aug 29, 2024 at 08:00:52AM +0900, Michael Paquier wrote:
>> Indeed, pg_sequence_read_tuple() would not reflect the reality, some
>> ideas:
>> - pg_sequence_read_data
>> - pg_sequence_get_data
>> - pg_sequence_data
>> - More
On Thu, Aug 29, 2024 at 08:00:52AM +0900, Michael Paquier wrote:
> On Mon, Aug 26, 2024 at 09:19:06AM -0500, Nathan Bossart wrote:
>> The patch looks reasonable to me. Do you think the name of the function
>> still makes sense now that 1) we might have different sequence AMs in the
>> near future
On Mon, Aug 26, 2024 at 09:19:06AM -0500, Nathan Bossart wrote:
> I am fine with changes to this function that would allow it to be
> generically useful for all sequence AMs, provided that it can still be used
> for dumpSequenceData(). I only included log_cnt because
> pg_sequence_read_tuple() is
On Mon, Aug 26, 2024 at 11:11:55AM +0900, Michael Paquier wrote:
> It seems to me that we'd live better without it, at least it matters
> for the sequence AM patch, because some of its callbacks are also
> shaped around the fact that WAL may not be required for sequence value
> computations. Provi
Hi all,
(Nathan in CC regarding c8b06bb969bf)
While rebasing my patch set for sequence AMs, I've looked at what has
been done with c8b06bb969bf and pg_sequence_read_tuple() because I can
reuse it in the sequence AM patch to grab the last value of a sequence
and if it has been called (the patch set
