Re: Removing WITH clause support in CREATE FUNCTION, for isCachable and isStrict

2018-01-26 Thread Michael Paquier
On Fri, Jan 26, 2018 at 12:30:12PM -0500, Tom Lane wrote: > And done. I failed to resist the temptation to rename > compute_attributes_sql_style, since the "sql_style" bit no longer > conveys anything. I'd always found compute_attributes_with_style > to be confusingly named --- seemed like it sho

Re: Removing WITH clause support in CREATE FUNCTION, for isCachable and isStrict

2018-01-26 Thread Robert Haas
On Fri, Jan 26, 2018 at 12:30 PM, Tom Lane wrote: > Michael Paquier writes: >> On Thu, Jan 25, 2018 at 06:30:04PM -0500, Tom Lane wrote: >>> In short, I'm on board with removing the WITH clause. I've not >>> reviewed the patch in detail, but will do so and push it if there's >>> not objections p

Re: Removing WITH clause support in CREATE FUNCTION, for isCachable and isStrict

2018-01-26 Thread Tom Lane
Michael Paquier writes: > On Thu, Jan 25, 2018 at 06:30:04PM -0500, Tom Lane wrote: >> In short, I'm on board with removing the WITH clause. I've not >> reviewed the patch in detail, but will do so and push it if there's >> not objections pretty soon. > Glad to hear that, thanks! And done. I f

Re: Removing WITH clause support in CREATE FUNCTION, for isCachable and isStrict

2018-01-25 Thread Michael Paquier
On Thu, Jan 25, 2018 at 06:30:04PM -0500, Tom Lane wrote: > I poked into the git log and confirmed Michael's statement that > CREATE FUNCTION ... WITH has been documented as deprecated since > 7.3 (commit 94bdc4855 to be exact). Thanks for the confirmation. > I think the original intention was th

Re: Removing WITH clause support in CREATE FUNCTION, for isCachable and isStrict

2018-01-25 Thread Tom Lane
Daniel Gustafsson writes: >> On 15 Jan 2018, at 03:27, Michael Paquier wrote: >> As noticed by Daniel here: >> https://www.postgresql.org/message-id/d5f34c9d-3ab7-4419-af2e-12f67581d...@yesql.se > In that thread I proposed a patch to fix this, but I certainly don’t object to > just removing it t

Re: Removing WITH clause support in CREATE FUNCTION, for isCachable and isStrict

2018-01-15 Thread Daniel Gustafsson
> On 15 Jan 2018, at 03:27, Michael Paquier wrote: > > Hi all, > > As noticed by Daniel here: > https://www.postgresql.org/message-id/d5f34c9d-3ab7-4419-af2e-12f67581d...@yesql.se In that thread I proposed a patch to fix this, but I certainly don’t object to just removing it to make both syntax

Removing WITH clause support in CREATE FUNCTION, for isCachable and isStrict

2018-01-14 Thread Michael Paquier
Hi all, As noticed by Daniel here: https://www.postgresql.org/message-id/d5f34c9d-3ab7-4419-af2e-12f67581d...@yesql.se Using a WITH clause takes precendence over what is defined in the main function definition when using isStrict and isCachable. For example, when using VOLATILE and IMMUTABLE, an