Re: Removed unused param isSlice of function transformAssignmentSubscripts

2022-09-17 Thread Michael Paquier
On Tue, Sep 13, 2022 at 03:20:01PM +0800, Richard Guo wrote: > +1. Good catch. Yes, you are right that this comes from c7aba7c that has changed the transform logic and the check on slicing support, and this makes the code easier to follow. So, applied. -- Michael signature.asc Description: PGP

Re: Removed unused param isSlice of function transformAssignmentSubscripts

2022-09-13 Thread Richard Guo
On Tue, Sep 13, 2022 at 11:35 AM Zhang Mingli wrote: > Param isSlice was once used to identity targetTypeId for > transformAssignmentIndirection. > > In commit c7aba7c14e, the evaluation was pushed down to > transformContainerSubscripts. > > No need to keep isSlice around transformAssignmentSubsc

Removed unused param isSlice of function transformAssignmentSubscripts

2022-09-12 Thread Zhang Mingli
Hi, Param isSlice was once used to identity targetTypeId for transformAssignmentIndirection. In commit c7aba7c14e, the evaluation was pushed down to transformContainerSubscripts. No need to keep isSlice around transformAssignmentSubscripts. Attach a patch to remove it. Regards, Zhang Mingli