Re: Reply: Remove useless param for create_groupingsets_path

2022-07-01 Thread Tom Lane
XueJing Zhao writes: > You are right, The patch is incorrect, and I generate a patch once more, It > is sent as as attachment named new,patch, please check, thanks! LGTM. Pushed, thanks! regards, tom lane

Reply: Remove useless param for create_groupingsets_path

2022-06-14 Thread XueJing Zhao
useless param for create_groupingsets_path On Wed, Jun 15, 2022 at 11:33 AM XueJing Zhao mailto:zxuej...@vmware.com>> wrote: Recently I work on grouping sets and I find the last param numGroups of create_groupingsets_path is not used. In create_groupingsets_path we use rollup->numGro

Re: Remove useless param for create_groupingsets_path

2022-06-14 Thread Richard Guo
On Wed, Jun 15, 2022 at 11:33 AM XueJing Zhao wrote: > Recently I work on grouping sets and I find the last param numGroups of > create_groupingsets_path is not used. > > In create_groupingsets_path we use rollup->numGroups to do cost_agg. > Yes indeed. The param 'numGroups' was used originally

Remove useless param for create_groupingsets_path

2022-06-14 Thread XueJing Zhao
Dear Postgres, Recently I work on grouping sets and I find the last param numGroups of create_groupingsets_path is not used. In create_groupingsets_path we use rollup->numGroups to do cost_agg. So I remove the param numGroups for create_groupingsets_path. I generate a diff.patch, which is sent