Hi,
On Fri, Nov 28, 2025 at 01:39:19PM -0500, Andres Freund wrote:
> I am pretty unconvinced this kind of stuff is worth the noise they produce in
> the more general case too.
I agree that it's noisy and time consuming to review, that's the drawback of
using
automated tools when they find and pr
On Fri, Nov 28, 2025 at 2:54 PM Bertrand Drouvot
wrote:
>
> RetainDeadTuplesData *rdt_data in can_advance_nonremovable_xid(): 228c37086855
> RetainDeadTuplesData *rdt_data in resume_conflict_info_retention():
> 0d48d393d465
>
All nearby static functions introduced for the same feature have
passe
Hi,
On 2025-11-28 18:29:15 +, Bertrand Drouvot wrote:
> On Fri, Nov 28, 2025 at 12:14:08PM -0500, Andres Freund wrote:
> > On 2025-11-28 09:24:23 +, Bertrand Drouvot wrote:
> > > PFA a patch to remove unused function parameters in replication (means
> > > focusing on src/backend/replicatio
Hi,
On Fri, Nov 28, 2025 at 12:14:08PM -0500, Andres Freund wrote:
> Hi,
>
> On 2025-11-28 09:24:23 +, Bertrand Drouvot wrote:
> > PFA a patch to remove unused function parameters in replication (means
> > focusing on src/backend/replication).
> >
> > Those have been detected by a coccinelle
Hi,
On 2025-11-28 09:24:23 +, Bertrand Drouvot wrote:
> PFA a patch to remove unused function parameters in replication (means
> focusing on src/backend/replication).
>
> Those have been detected by a coccinelle script (that I need to polish before
> sharing). It currently only focuses on sta
Hi hackers,
PFA a patch to remove unused function parameters in replication (means
focusing on src/backend/replication).
Those have been detected by a coccinelle script (that I need to polish before
sharing). It currently only focuses on static functions.
While reviewing the coccinelle script ou
