Re: Remove unused function parameters, part 1: contrib

2025-11-27 Thread Bertrand Drouvot
Hi, On Thu, Nov 27, 2025 at 03:07:17PM +0300, Nazir Bilal Yavuz wrote: > On Thu, 27 Nov 2025 at 11:57, Bertrand Drouvot > wrote: > > > > The patches are split by modules to ease the review. > > I applied all patches and built/tested without any errors. So I guess > that the changes are correct.

Re: Remove unused function parameters, part 1: contrib

2025-11-27 Thread Bertrand Drouvot
Hi, On Thu, Nov 27, 2025 at 02:39:39PM +0300, Kirill Reshke wrote: > On Thu, 27 Nov 2025 at 11:57, Bertrand Drouvot > wrote: > > > > For 0005 (collid not used in internal_citext_pattern_cmp()) I think that the > > unused column should be used (as done in 0005) due to an oversight in commit > > f2

Re: Remove unused function parameters, part 1: contrib

2025-11-27 Thread Nazir Bilal Yavuz
Hi, Thank you for working on this! On Thu, 27 Nov 2025 at 11:57, Bertrand Drouvot wrote: > > Hi hackers, > > PFA patches to remove unused function parameters in contrib (more patches will > come for non contrib). > > The patches are split by modules to ease the review. I applied all patches and

Re: Remove unused function parameters, part 1: contrib

2025-11-27 Thread Kirill Reshke
On Thu, 27 Nov 2025 at 11:57, Bertrand Drouvot wrote: > > Hi hackers, > > PFA patches to remove unused function parameters in contrib (more patches will > come for non contrib). > > The patches are split by modules to ease the review. > > For 0005 (collid not used in internal_citext_pattern_cmp())

Remove unused function parameters, part 1: contrib

2025-11-27 Thread Bertrand Drouvot
Hi hackers, PFA patches to remove unused function parameters in contrib (more patches will come for non contrib). The patches are split by modules to ease the review. For 0005 (collid not used in internal_citext_pattern_cmp()) I think that the unused column should be used (as done in 0005) due t