On Sun, Nov 23, 2025 at 12:27:08PM +0800, Chao Li wrote:
> 1. "This loop stores into os_page_ptrs[]” is understandable, but
> feels a bit incomplete to me as non-English-speaking. I understand
> your intention is to make “stores” and “touches” to share
> “addresses”. But this is not a strong opinio
> On Nov 21, 2025, at 19:34, Bertrand Drouvot
> wrote:
>
> Hi hackers,
>
> While working on [1], I noticed that there are unused fields in
> BufferCacheNumaRec
> since ba2a3c2302f.
>
> Also, I noticed that a comment was not at the correct location in
> pg_buffercache_numa_pages().
>
> Th
On Fri, Nov 21, 2025 at 11:34:01AM +, Bertrand Drouvot wrote:
> While working on [1], I noticed that there are unused fields in
> BufferCacheNumaRec
> since ba2a3c2302f.
>
> Also, I noticed that a comment was not at the correct location in
> pg_buffercache_numa_pages().
>
> The attached tak
Nov 2025 05:53:50 +
Subject: [PATCH v1] Remove unused fields from BufferCacheNumaRec
These were added by ba2a3c2302f and never been used.
Also move (and re-word a bit) a comment that was not at the right place.
---
contrib/pg_buffercache/pg_buffercache_pages.c | 13 +
1 file changed