Re: Remove unneeded PGDATABASE setting from TAP tests

2024-01-02 Thread Michael Paquier
On Mon, Jan 01, 2024 at 01:52:10PM +0530, Bharath Rupireddy wrote: > Oh, yeah. We can remove that too, after all, PGDATABASE is being set > to postgres the default database which PostgreSQL::Test::Cluster does > set for us. I was earlier swayed by the comment atop the PGDATABASE > setting in 011_cl

Re: Remove unneeded PGDATABASE setting from TAP tests

2024-01-01 Thread Bharath Rupireddy
On Sun, Dec 31, 2023 at 8:36 AM Michael Paquier wrote: > > On Sun, Dec 31, 2023 at 07:24:08AM +0530, Bharath Rupireddy wrote: > > Some of the TAP tests are explicitly setting PGDATABASE environment > > variable to 'postgres', which isn't needed because the TAP test's perl > > library PostgreSQL::T

Re: Remove unneeded PGDATABASE setting from TAP tests

2023-12-30 Thread Michael Paquier
On Sun, Dec 31, 2023 at 07:24:08AM +0530, Bharath Rupireddy wrote: > Some of the TAP tests are explicitly setting PGDATABASE environment > variable to 'postgres', which isn't needed because the TAP test's perl > library PostgreSQL::Test::Cluster already sets it once and for all. > I've attached a p

Remove unneeded PGDATABASE setting from TAP tests

2023-12-30 Thread Bharath Rupireddy
emove unneeded PGDATABASE setting from TAP tests Some of the TAP tests are explicitly setting PGDATABASE environment variable to 'postgres', which isn't needed because the TAP test's perl library PostgreSQL::Test::Cluster already sets it once and for all. This commit removes al