Re: Remove unnecessary relabel stripping

2020-05-01 Thread Tomas Vondra
On Thu, Apr 30, 2020 at 01:40:11PM +0900, Michael Paquier wrote: On Thu, Apr 30, 2020 at 09:37:41AM +0800, Richard Guo wrote: On Thu, Apr 30, 2020 at 8:11 AM Tomas Vondra wrote:> FWIW it'd be better to send the patch to the original thread instead of starting a new one. Ah yes, you're right.

Re: Remove unnecessary relabel stripping

2020-04-29 Thread Michael Paquier
On Thu, Apr 30, 2020 at 09:37:41AM +0800, Richard Guo wrote: > On Thu, Apr 30, 2020 at 8:11 AM Tomas Vondra > wrote:> >> FWIW it'd be better to send the patch to the original thread instead of >> starting a new one. > > Ah yes, you're right. Sorry for not doing so. FWIW, I don't find the move fr

Re: Remove unnecessary relabel stripping

2020-04-29 Thread Richard Guo
On Thu, Apr 30, 2020 at 8:11 AM Tomas Vondra wrote: > On Wed, Apr 29, 2020 at 03:51:40PM +0800, Richard Guo wrote: > >Hi hackers, > > > >Per discussion in [1], we don't need to strip relabel for the expr > >explicitly before calling pull_varnos() to retrieve all mentioned > >relids. pull_varnos()

Re: Remove unnecessary relabel stripping

2020-04-29 Thread Tomas Vondra
On Wed, Apr 29, 2020 at 03:51:40PM +0800, Richard Guo wrote: Hi hackers, Per discussion in [1], we don't need to strip relabel for the expr explicitly before calling pull_varnos() to retrieve all mentioned relids. pull_varnos() would recurse into T_RelabelType nodes. Add a patch to remove that

Remove unnecessary relabel stripping

2020-04-29 Thread Richard Guo
Hi hackers, Per discussion in [1], we don't need to strip relabel for the expr explicitly before calling pull_varnos() to retrieve all mentioned relids. pull_varnos() would recurse into T_RelabelType nodes. Add a patch to remove that and simplify the code a bit. [1] https://www.postgresql.org/me