Re: Remove remnants of "snapshot too old"

2024-12-04 Thread Nathan Bossart
On Wed, Dec 04, 2024 at 09:55:43AM +0200, Heikki Linnakangas wrote: > On 04/12/2024 03:24, Tom Lane wrote: >> Andres Freund writes: >> > Most of this I agree with. But I'm not sure just removing the toast >> > snapshot >> > stuff is good - we've had a bunch of bugs where we don't hold a snapshot

Re: Remove remnants of "snapshot too old"

2024-12-03 Thread Heikki Linnakangas
On 04/12/2024 03:24, Tom Lane wrote: Andres Freund writes: On 2024-12-03 22:06:59 +0200, Heikki Linnakangas wrote: I spotted some more remnants of the "snapshot too old" feature that was removed in v17. Barring objections, I will commit the attached patch to tidy up. Most of this I agree wi

Re: Remove remnants of "snapshot too old"

2024-12-03 Thread Tom Lane
Andres Freund writes: > On 2024-12-03 22:06:59 +0200, Heikki Linnakangas wrote: >> I spotted some more remnants of the "snapshot too old" feature that was >> removed in v17. Barring objections, I will commit the attached patch to tidy >> up. > Most of this I agree with. But I'm not sure just remo

Re: Remove remnants of "snapshot too old"

2024-12-03 Thread Andres Freund
Hi, On 2024-12-03 22:06:59 +0200, Heikki Linnakangas wrote: > I spotted some more remnants of the "snapshot too old" feature that was > removed in v17. Barring objections, I will commit the attached patch to tidy > up. Most of this I agree with. But I'm not sure just removing the toast snapshot s

Re: Remove remnants of "snapshot too old"

2024-12-03 Thread Nathan Bossart
On Tue, Dec 03, 2024 at 10:06:59PM +0200, Heikki Linnakangas wrote: > -/* -- > - * init_toast_snapshot > - * > - * Initialize an appropriate TOAST snapshot. We must use an MVCC snapshot > - * to initialize the TOAST snapshot; since we don't know which one to use, > - * just use the o

Remove remnants of "snapshot too old"

2024-12-03 Thread Heikki Linnakangas
I spotted some more remnants of the "snapshot too old" feature that was removed in v17. Barring objections, I will commit the attached patch to tidy up. -- Heikki Linnakangas Neon (https://neon.tech) From a24f69e0bcf38721e5ffe2c7b65f9901fa8b079d Mon Sep 17 00:00:00 2001 From: Heikki Linnakangas