On 27/10/2018 23:19, Daniel Gustafsson wrote:
>> On 27 Oct 2018, at 12:57, Peter Eisentraut
>> wrote:
>>
>> On 23/10/2018 19:48, Daniel Gustafsson wrote:
On 23 Oct 2018, at 15:17, Peter Eisentraut
wrote:
I propose the attached patch to remove the long-unused catalog column
>
> On 27 Oct 2018, at 12:57, Peter Eisentraut
> wrote:
>
> On 23/10/2018 19:48, Daniel Gustafsson wrote:
>>> On 23 Oct 2018, at 15:17, Peter Eisentraut
>>> wrote:
>>>
>>> I propose the attached patch to remove the long-unused catalog column
>>> pg_attrdef.adsrc.
>>
>> +1, I ran into a bug in
27 Oct 2018 11:25:20 +0100
Subject: [PATCH v2 1/2] Remove obsolete pg_attrdef.adsrc column
This has been deprecated and effectively unused for a long time.
---
doc/src/sgml/catalogs.sgml | 20 +++-
src/backend/catalog/heap.c | 12
src/include/catalog/pg_attrdef
> On 23 Oct 2018, at 15:17, Peter Eisentraut
> wrote:
>
> I propose the attached patch to remove the long-unused catalog column
> pg_attrdef.adsrc.
+1, I ran into a bug in an app as recently as today where adsrc was used
instead of pg_get_expr().
Patch looks good. I probably would’ve opted fo
On 2018-Oct-23, Peter Eisentraut wrote:
> I propose the attached patch to remove the long-unused catalog column
> pg_attrdef.adsrc.
+1, looks good. I think this change has been waiting for a very long
time -- documented as useless by 81c41e3d0ed3 (Jan 2005, general doc
copy-edit, a paragraph you
From: Peter Eisentraut
Date: Tue, 23 Oct 2018 14:58:40 +0200
Subject: [PATCH] Remove obsolete pg_attrdef.adsrc column
This has been deprecated and effectively unused for a long time.
---
doc/src/sgml/catalogs.sgml | 16
src/backend/catalog/heap.c | 12
