On 2020-01-15 07:44, Michael Paquier wrote:
I have been testing and checking the patch a bit more seriously, and
the information gets generated correctly for dlls and exe files. The
rest of the changes look fine to me. For src/makefiles/Makefile.win32,
I don't have a MinGW environment at hand s
On Wed, Jan 15, 2020 at 02:22:45PM +0900, Kyotaro Horiguchi wrote:
> At Tue, 14 Jan 2020 22:34:10 +0100, Peter Eisentraut
> wrote in
>> On 2020-01-09 10:56, Peter Eisentraut wrote:
>>> Note that there is FILEFLAGSMASK and FILEFLAGS. The first is just a
>>> mask that says which bits in the secon
At Tue, 14 Jan 2020 22:34:10 +0100, Peter Eisentraut
wrote in
> On 2020-01-09 10:56, Peter Eisentraut wrote:
> > On 2020-01-06 09:02, Michael Paquier wrote:
> >> - FILEFLAGSMASK 0x17L
> >> + FILEFLAGSMASK VS_FFI_FILEFLAGSMASK
> >> Are you sure with the mapping here? I would have thought that
//www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>From 53607c4344f098a6ea2460b9b21715433199a664 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Tue, 14 Jan 2020 21:18:29 +0100
Subject: [PATCH v2] Remove libpq.rc, use win32ver.rc for libpq
For histor
On 2020-01-06 09:02, Michael Paquier wrote:
- FILEFLAGSMASK 0x17L
+ FILEFLAGSMASK VS_FFI_FILEFLAGSMASK
Are you sure with the mapping here? I would have thought that
VS_FF_DEBUG is not necessary when using release-quality builds, which
is something that can be configured with build.pl, and that
On Fri, Dec 27, 2019 at 05:25:58PM +0100, Peter Eisentraut wrote:
> I was wondering why we have a separate libpq.rc for libpq and use
> win32ver.rc for all other components. I suspect this is also a leftover
> from the now-removed client-only Windows build. With a bit of tweaking we
> can use win
ices
From 3dc66959415e91d313851bd6db5cb271c5d9ac2d Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Fri, 27 Dec 2019 17:17:14 +0100
Subject: [PATCH] Remove libpq.rc, use win32ver.rc for libpq
For historical reasons, libpq used a separate libpq.rc file for the
Windows builds while all other compone
