Re: Remove emode argument from XLogFileRead/XLogFileReadAnyTLI

2024-09-09 Thread Michael Paquier
On Mon, Sep 09, 2024 at 05:45:13PM +0900, Yugo NAGATA wrote: > I mean to remove emode from XLogFileRead, too, but this fix is accidentally > missed in the previous patch. I attached the updated patch. This is neat because we don't need to guess how XLogFileRead() should fail on PANIC, allow things

Re: Remove emode argument from XLogFileRead/XLogFileReadAnyTLI

2024-09-09 Thread Yugo NAGATA
On Mon, 9 Sep 2024 12:16:01 +0900 Michael Paquier wrote: > On Fri, Sep 06, 2024 at 08:10:43PM +0900, Yugo Nagata wrote: > > Since 1bb2558046c, XLogFileRead() doesn't use the emode argument. > > Also, since abf5c5c9a4f, XLogFileReadAnyTLI() is called just once > > and emode is always DEBUG2. So,

Re: Remove emode argument from XLogFileRead/XLogFileReadAnyTLI

2024-09-08 Thread Michael Paquier
On Fri, Sep 06, 2024 at 08:10:43PM +0900, Yugo Nagata wrote: > Since 1bb2558046c, XLogFileRead() doesn't use the emode argument. > Also, since abf5c5c9a4f, XLogFileReadAnyTLI() is called just once > and emode is always DEBUG2. So, I think we can remove the emode > argument from these functions. I'

Remove emode argument from XLogFileRead/XLogFileReadAnyTLI

2024-09-06 Thread Yugo Nagata
Hi, Since 1bb2558046c, XLogFileRead() doesn't use the emode argument. Also, since abf5c5c9a4f, XLogFileReadAnyTLI() is called just once and emode is always DEBUG2. So, I think we can remove the emode argument from these functions. I've atached the patch. Regards, Yugo Nagata -- Yugo Nagata di