Re: Remove an unnecessary check on semijoin_target_ok() on postgres_fdw.c

2025-04-05 Thread Tender Wang
Alexander Korotkov 于2025年3月25日周二 18:57写道: > On Fri, Nov 29, 2024 at 3:39 AM Tender Wang wrote: > > Alexander Pyhalov 于2024年11月29日周五 00:02写道: > >> > >> Tender Wang писал(а) 2024-10-09 10:26: > >> > Hi, > >> >When I debug FDW join pushdown codes, I found below codes in > >> > semijoin_target_

Re: Remove an unnecessary check on semijoin_target_ok() on postgres_fdw.c

2025-04-05 Thread Alexander Korotkov
On Fri, Nov 29, 2024 at 3:39 AM Tender Wang wrote: > Alexander Pyhalov 于2024年11月29日周五 00:02写道: >> >> Tender Wang писал(а) 2024-10-09 10:26: >> > Hi, >> >When I debug FDW join pushdown codes, I found below codes in >> > semijoin_target_ok(): >> > if (bms_is_member(var->varno, innerrel->rel

Re: Remove an unnecessary check on semijoin_target_ok() on postgres_fdw.c

2024-11-28 Thread Tender Wang
Alexander Pyhalov 于2024年11月29日周五 00:02写道: > Tender Wang писал(а) 2024-10-09 10:26: > > Hi, > >When I debug FDW join pushdown codes, I found below codes in > > semijoin_target_ok(): > > if (bms_is_member(var->varno, innerrel->relids) && > > > > !bms_is_member(var->varno, outerrel->

Re: Remove an unnecessary check on semijoin_target_ok() on postgres_fdw.c

2024-11-28 Thread Alexander Pyhalov
Tender Wang писал(а) 2024-10-09 10:26: Hi, When I debug FDW join pushdown codes, I found below codes in semijoin_target_ok(): if (bms_is_member(var->varno, innerrel->relids) && !bms_is_member(var->varno, outerrel->relids)) As far as I know, if a var belongs to the innerrel of joi

Remove an unnecessary check on semijoin_target_ok() on postgres_fdw.c

2024-10-09 Thread Tender Wang
Hi, When I debug FDW join pushdown codes, I found below codes in semijoin_target_ok(): if (bms_is_member(var->varno, innerrel->relids) && !bms_is_member(var->varno, outerrel->relids)) As far as I know, if a var belongs to the innerrel of joinrel, it's not possible that it may belong