On Wed, Oct 12, 2022 at 12:24 AM Alvaro Herrera
wrote:
> Knowing how difficult that code was, and how heroic was to change it to
> a more maintainable form, I place no blame on failing to notice that
> some small thing could have been written more easily.
Concur with that. The changes in 7fcbf6
On Tue, Oct 11, 2022 at 06:24:26PM +0200, Alvaro Herrera wrote:
> Knowing how difficult that code was, and how heroic was to change it to
> a more maintainable form, I place no blame on failing to notice that
> some small thing could have been written more easily.
+1. And even after such changes
On 2022-Oct-11, Richard Guo wrote:
> As I can see in 7fcbf6a4 ValidXLogPageHeader() is refactored as
True, but look at dfda6ebaec67 -- that changed the use of recaddr from
being built from parts (which were globals back then) into something
that was computed locally.
Knowing how difficult that c
On Tue, Oct 11, 2022 at 7:05 PM Bharath Rupireddy <
bharath.rupireddyforpostg...@gmail.com> wrote:
> On Tue, Oct 11, 2022 at 3:19 PM Richard Guo
> wrote:
> > On Tue, Oct 11, 2022 at 1:44 PM Kyotaro Horiguchi <
> horikyota@gmail.com> wrote:
> >> At Mon, 10 Oct 2022 08:53:55 +0530, Bharath Rupi
On Tue, Oct 11, 2022 at 3:19 PM Richard Guo wrote:
>
>
> On Tue, Oct 11, 2022 at 1:44 PM Kyotaro Horiguchi
> wrote:
>>
>> At Mon, 10 Oct 2022 08:53:55 +0530, Bharath Rupireddy
>> wrote in
>> > It looks like we have an unnecessary XLogSegNoOffsetToRecPtr() in
>> > XLogReaderValidatePageHeader()
On Tue, Oct 11, 2022 at 1:44 PM Kyotaro Horiguchi
wrote:
> At Mon, 10 Oct 2022 08:53:55 +0530, Bharath Rupireddy <
> bharath.rupireddyforpostg...@gmail.com> wrote in
> > It looks like we have an unnecessary XLogSegNoOffsetToRecPtr() in
> > XLogReaderValidatePageHeader(). We pass the start LSN of
At Mon, 10 Oct 2022 08:53:55 +0530, Bharath Rupireddy
wrote in
> It looks like we have an unnecessary XLogSegNoOffsetToRecPtr() in
> XLogReaderValidatePageHeader(). We pass the start LSN of the WAL page
> and check if it matches with the LSN that was stored in the WAL page
> header (xlp_pageaddr
tps://aws.amazon.com
From c831b7fdd6a0b053fedbf37b2bbda5d73739d42f Mon Sep 17 00:00:00 2001
From: Bharath Rupireddy
Date: Sun, 9 Oct 2022 09:53:39 +
Subject: [PATCH v1] Remove an unnecessary LSN calculation while validating WAL
page header
---
src/backend/access/transam/xlogreader.c | 5 +
1
