Re: Remove all "INTERFACE ROUTINES" style comments

2019-01-14 Thread Heikki Linnakangas
On 12/01/2019 03:12, Andres Freund wrote: On 2019-01-10 15:58:41 -0800, Andres Freund wrote: A number of postgres files have sections like heapam's * INTERFACE ROUTINES ... They're often out-of-date, and I personally never found them to be useful. A few people, including yours truly, have bee

Re: Remove all "INTERFACE ROUTINES" style comments

2019-01-11 Thread Michael Paquier
On Fri, Jan 11, 2019 at 12:02:22PM -0500, Robert Haas wrote: > On Thu, Jan 10, 2019 at 7:05 PM Thomas Munro > wrote: > > +1 > > +1 +1. -- Michael signature.asc Description: PGP signature

Re: Remove all "INTERFACE ROUTINES" style comments

2019-01-11 Thread Andres Freund
Hi, On 2019-01-10 15:58:41 -0800, Andres Freund wrote: > A number of postgres files have sections like heapam's > > * INTERFACE ROUTINES > ... > They're often out-of-date, and I personally never found them to be > useful. A few people, including yours truly, have been removing a few > here and t

Re: Remove all "INTERFACE ROUTINES" style comments

2019-01-11 Thread Robert Haas
On Thu, Jan 10, 2019 at 7:05 PM Thomas Munro wrote: > +1 +1 -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: Remove all "INTERFACE ROUTINES" style comments

2019-01-10 Thread Tom Lane
Thomas Munro writes: > On Fri, Jan 11, 2019 at 12:58 PM Andres Freund wrote: >> A number of postgres files have sections like heapam's >> * INTERFACE ROUTINES >> >> They're often out-of-date, and I personally never found them to be >> useful. A few people, including yours truly, have been removi

Re: Remove all "INTERFACE ROUTINES" style comments

2019-01-10 Thread Thomas Munro
On Fri, Jan 11, 2019 at 12:58 PM Andres Freund wrote: > A number of postgres files have sections like heapam's > > * INTERFACE ROUTINES > * relation_open - open any relation by relation OID > * relation_openrv - open any relation specified by a RangeVar > * relation_close - c

Remove all "INTERFACE ROUTINES" style comments

2019-01-10 Thread Andres Freund
Hi, A number of postgres files have sections like heapam's * INTERFACE ROUTINES * relation_open - open any relation by relation OID * relation_openrv - open any relation specified by a RangeVar * relation_close - close any relation * heap_open - open a heap relat