Re: Remove a redundant condition check

2020-06-26 Thread Amit Kapila
On Fri, Jun 26, 2020 at 3:32 PM Michael Paquier wrote: > > On Fri, Jun 26, 2020 at 02:39:22PM +0530, Amit Kapila wrote: > > It seems we forgot to remove the additional check for switchedTLI > > while adding a new check. I think we can remove this duplicate check > > in the HEAD code. I am not su

RE: Remove a redundant condition check

2020-06-26 Thread Ádám Balogh
Hello, -Original Message- From: Amit Kapila Sent: 2020. június 26., péntek 11:09 To: Ádám Balogh Cc: PostgreSQL Hackers Subject: Re: Remove a redundant condition check >On Thu, Jun 25, 2020 at 11:23 PM Ádám Balogh wrote: >> >> >> A one line change to remove a

Re: Remove a redundant condition check

2020-06-26 Thread Ranier Vilela
Em sex., 26 de jun. de 2020 às 06:09, Amit Kapila escreveu: > On Thu, Jun 25, 2020 at 11:23 PM Ádám Balogh > wrote: > > > > > > A one line change to remove a duplicate check. This duplicate check was > detected during testing my contribution to a static code analysis tool. > There is no function

Re: Remove a redundant condition check

2020-06-26 Thread Michael Paquier
On Fri, Jun 26, 2020 at 02:39:22PM +0530, Amit Kapila wrote: > It seems we forgot to remove the additional check for switchedTLI > while adding a new check. I think we can remove this duplicate check > in the HEAD code. I am not sure if it is worth to backpatch such a > change. Yes, there is no

Re: Remove a redundant condition check

2020-06-26 Thread Amit Kapila
On Thu, Jun 25, 2020 at 11:23 PM Ádám Balogh wrote: > > > A one line change to remove a duplicate check. This duplicate check was > detected during testing my contribution to a static code analysis tool. There > is no functional change, no new tests needed. > > Yeah, this duplicate check is add

Remove a redundant condition check

2020-06-25 Thread Ádám Balogh
Hello, A one line change to remove a duplicate check. This duplicate check was detected during testing my contribution to a static code analysis tool. There is no functional change, no new tests needed. Regards, Ádám Balogh CodeChecker Team Ericsson Hungary v1-0001-Remove-redundant-condition