Re: Remove INT64_FORMAT in translatable strings

2022-03-18 Thread Japin Li
On Sat, 19 Mar 2022 at 01:12, Tom Lane wrote: > Japin Li writes: >> we can rely on %lld/%llu and we decided to use them in translatable strings. > > Seems like good cleanup, so pushed. I think though that project style > is to use "long long" or "unsigned long long", without the unnecessary >

Re: Remove INT64_FORMAT in translatable strings

2022-03-18 Thread Justin Pryzby
On Fri, Mar 18, 2022 at 01:12:40PM -0400, Tom Lane wrote: > Japin Li writes: > > we can rely on %lld/%llu and we decided to use them in translatable strings. > > Seems like good cleanup, so pushed. I think though that project style > is to use "long long" or "unsigned long long", without the unn

Re: Remove INT64_FORMAT in translatable strings

2022-03-18 Thread Tom Lane
Japin Li writes: > we can rely on %lld/%llu and we decided to use them in translatable strings. Seems like good cleanup, so pushed. I think though that project style is to use "long long" or "unsigned long long", without the unnecessary "int" --- it certainly makes little sense to do it both way

Remove INT64_FORMAT in translatable strings

2022-03-18 Thread Japin Li
Hi, I found the following lines in pg_backup_tar.c. if (len != th->fileLen) { charbuf1[32], buf2[32]; snprintf(buf1, sizeof(buf1), INT64_FORMAT, (int64) len); snprintf(buf2, sizeof(buf2), INT64_FORMAT, (int64) th->fileLen); fat