Re: Removal of unnecessary CommandCounterIncrement() when doing ON COMMIT DELETE ROWS

2018-11-12 Thread Michael Paquier
On Mon, Nov 12, 2018 at 01:19:31PM -0300, Alvaro Herrera wrote: > On 2018-Nov-09, Michael Paquier wrote: >> When doing a set of ON COMMIT DELETE ROWS actions for relations, there >> is a CCI happening after each truncation: > > Right, but note that this is not a loop so it's only one CCI, not one

Re: Removal of unnecessary CommandCounterIncrement() when doing ON COMMIT DELETE ROWS

2018-11-12 Thread Alvaro Herrera
On 2018-Nov-09, Michael Paquier wrote: > Hi all, > > When doing a set of ON COMMIT DELETE ROWS actions for relations, there > is a CCI happening after each truncation: Right, but note that this is not a loop so it's only one CCI, not one per relation. (This doesn't seem a big deal either way, b

Removal of unnecessary CommandCounterIncrement() when doing ON COMMIT DELETE ROWS

2018-11-08 Thread Michael Paquier
Hi all, When doing a set of ON COMMIT DELETE ROWS actions for relations, there is a CCI happening after each truncation: @@ -13334,10 +13334,8 @@ PreCommit_on_commit_actions(void) * exists at truncation time. */ if (oids_to_truncate != NIL) - { heap_truncate(oids_to_truncate)