Re: Regression tests failures on Windows Server 2019 - on master at commit # d816f366b

2022-03-19 Thread Andres Freund
On 2022-03-19 11:16:48 -0700, Andres Freund wrote: > Cirrus now provides a way to get the old behaviour back without pinning an old > agent version. See attached I've pushed that now. If we can come up with a better recipe for starting postgres in the background, cool. But until then...

Re: Regression tests failures on Windows Server 2019 - on master at commit # d816f366b

2022-03-19 Thread Andres Freund
Hi, On 2022-03-04 22:01:22 -0800, Andres Freund wrote: > On 2022-03-04 20:06:43 -0800, Andres Freund wrote: > > On 2022-03-05 16:39:21 +1300, Thomas Munro wrote: > > > I vote for committing that workaround into the tree temporarily, > > > because it's not just cfbot, it's also everyone's dev branc

Re: Regression tests failures on Windows Server 2019 - on master at commit # d816f366b

2022-03-05 Thread Andrew Dunstan
On 3/4/22 17:04, Andres Freund wrote: > Hi, > > On 2022-03-04 16:51:32 -0500, Tom Lane wrote: >> Andres Freund writes: >>> That fixed the immediate problem, but dblink, postgres_fdw tests failed: >>> +ERROR: could not establish connection >>> +DETAIL: connection to server at "localhost" (::1),

Re: Regression tests failures on Windows Server 2019 - on master at commit # d816f366b

2022-03-04 Thread Andres Freund
On 2022-03-04 20:06:43 -0800, Andres Freund wrote: > On 2022-03-05 16:39:21 +1300, Thomas Munro wrote: > > I vote for committing that workaround into the tree temporarily, > > because it's not just cfbot, it's also everyone's dev branches on > > Github + the official mirror that are red. > > I'll

Re: Regression tests failures on Windows Server 2019 - on master at commit # d816f366b

2022-03-04 Thread Andres Freund
Hi, On 2022-03-05 16:39:21 +1300, Thomas Munro wrote: > On Sat, Mar 5, 2022 at 4:19 PM Andres Freund wrote: > > https://github.com/cirruslabs/cirrus-ci-agent/issues/218#issuecomment-1059657781 > > Oof. Nice detective work. Thanks. > > As indicated in the message above it, there's a workaround

Re: Regression tests failures on Windows Server 2019 - on master at commit # d816f366b

2022-03-04 Thread Thomas Munro
On Sat, Mar 5, 2022 at 4:19 PM Andres Freund wrote: > https://github.com/cirruslabs/cirrus-ci-agent/issues/218#issuecomment-1059657781 Oof. Nice detective work. > As indicated in the message above it, there's a workaround. Not sure if worth > committing, if they were to fix it in a few days? c

Re: Regression tests failures on Windows Server 2019 - on master at commit # d816f366b

2022-03-04 Thread Andres Freund
Hi, On 2022-03-05 13:21:26 +1300, Thomas Munro wrote: > On Sat, Mar 5, 2022 at 10:56 AM Andres Freund wrote: > > I suspect one also needs the console detach thing. > > I tried adding DETACHED_PROCESS (which should be like calling > FreeConsole() in child process) and then I tried CREATE_NEW_CONSO

Re: Regression tests failures on Windows Server 2019 - on master at commit # d816f366b

2022-03-04 Thread Thomas Munro
On Sat, Mar 5, 2022 at 10:56 AM Andres Freund wrote: > I suspect one also needs the console detach thing. I tried adding DETACHED_PROCESS (which should be like calling FreeConsole() in child process) and then I tried CREATE_NEW_CONSOLE instead, on top of CREATE_NEW_PROCESS_GROUP. Neither helped,

Re: Regression tests failures on Windows Server 2019 - on master at commit # d816f366b

2022-03-04 Thread Andres Freund
On 2022-03-04 14:04:44 -0800, Andres Freund wrote: > Trying to make it use the current user now - I don't know what > permissions services are needed to run a service as a user or such. My first attempt of using %USERNAME% failed: [22:10:20.862] c:\cirrus>call tmp_install\bin\pg_ctl.exe register

Re: Regression tests failures on Windows Server 2019 - on master at commit # d816f366b

2022-03-04 Thread Tom Lane
Andres Freund writes: > I don't really understand why start_postmaster() bothers to wrap postmaster > start through cmd.exe, particularly when it prevents us from getting > postmaster's pid. Also the caveats around cmd.exe and sharing mode. I think the basic idea is to avoid having to write our o

Re: Regression tests failures on Windows Server 2019 - on master at commit # d816f366b

2022-03-04 Thread Andres Freund
Hi, On 2022-03-04 16:51:32 -0500, Tom Lane wrote: > Andres Freund writes: > > That fixed the immediate problem, but dblink, postgres_fdw tests failed: > > +ERROR: could not establish connection > > +DETAIL: connection to server at "localhost" (::1), port 5432 failed: > > FATAL: > > role "SYST

Re: Regression tests failures on Windows Server 2019 - on master at commit # d816f366b

2022-03-04 Thread Andres Freund
Hi, On 2022-03-05 09:29:01 +1300, Thomas Munro wrote: > On Sat, Mar 5, 2022 at 7:10 AM Andres Freund wrote: > > Or perhaps pg_ctl ought to pass CREATE_NEW_PROCESS_GROUP to CreateProcess()? > > The lack of a process group would explain why we're getting signalled on > > ctrl-c... > > I thought th

Re: Regression tests failures on Windows Server 2019 - on master at commit # d816f366b

2022-03-04 Thread Tom Lane
Andres Freund writes: > That fixed the immediate problem, but dblink, postgres_fdw tests failed: > +ERROR: could not establish connection > +DETAIL: connection to server at "localhost" (::1), port 5432 failed: FATAL: > role "SYSTEM" does not exist [ scratches head... ] Where is libpq getting

Re: Regression tests failures on Windows Server 2019 - on master at commit # d816f366b

2022-03-04 Thread Andres Freund
Hi, On 2022-03-04 09:57:35 -0800, Andres Freund wrote: > On 2022-03-04 09:46:44 -0800, Andres Freund wrote: > > On 2022-03-04 09:30:37 -0800, Andres Freund wrote: > > > I wonder if we're missing some steps, at least on windows, to make pg_ctl > > > start independent of the starting shell? > > > >

Re: Regression tests failures on Windows Server 2019 - on master at commit # d816f366b

2022-03-04 Thread Thomas Munro
On Sat, Mar 5, 2022 at 7:10 AM Andres Freund wrote: > Or perhaps pg_ctl ought to pass CREATE_NEW_PROCESS_GROUP to CreateProcess()? > The lack of a process group would explain why we're getting signalled on > ctrl-c... I thought that sounded promising, given that the recent Cirrus agent commit you

Re: Regression tests failures on Windows Server 2019 - on master at commit # d816f366b

2022-03-04 Thread Andres Freund
Hi, On 2022-03-04 09:57:35 -0800, Andres Freund wrote: > On 2022-03-04 09:46:44 -0800, Andres Freund wrote: > > On 2022-03-04 09:30:37 -0800, Andres Freund wrote: > > > I wonder if we're missing some steps, at least on windows, to make pg_ctl > > > start independent of the starting shell? > > > >

Re: Regression tests failures on Windows Server 2019 - on master at commit # d816f366b

2022-03-04 Thread Andres Freund
On 2022-03-04 09:46:44 -0800, Andres Freund wrote: > On 2022-03-04 09:30:37 -0800, Andres Freund wrote: > > I wonder if we're missing some steps, at least on windows, to make pg_ctl > > start independent of the starting shell? > > Sure looks that way. On windows, if I do pg_ctl start, then hit ctrl

Re: Regression tests failures on Windows Server 2019 - on master at commit # d816f366b

2022-03-04 Thread Andres Freund
Hi, On 2022-03-04 09:30:37 -0800, Andres Freund wrote: > I wonder if we're missing some steps, at least on windows, to make pg_ctl > start independent of the starting shell? Sure looks that way. On windows, if I do pg_ctl start, then hit ctrl-c, the server shuts down. Greetings, Andres Freund

Re: Regression tests failures on Windows Server 2019 - on master at commit # d816f366b

2022-03-04 Thread Tom Lane
Andres Freund writes: > On 2022-03-04 12:23:43 -0500, Tom Lane wrote: >> pg_regress thinks the postmaster is listening to a Unix socket. > pg_regress outputs the above message when neither PGHOST, PGPORT or > --host/--port are set. On windows that nevertheless ends up with connecting to > localho

Re: Regression tests failures on Windows Server 2019 - on master at commit # d816f366b

2022-03-04 Thread Andres Freund
Hi, On 2022-03-04 12:23:43 -0500, Tom Lane wrote: > Actually ... looking closer at the failure log: > > [09:41:50.589] Checking plpgsql > [09:41:50.608] (using postmaster on Unix socket, default port) > ^^^ > [09:41:50.608] == dropping datab

Re: Regression tests failures on Windows Server 2019 - on master at commit # d816f366b

2022-03-04 Thread Andres Freund
Hi, On 2022-03-04 09:10:14 -0800, Andres Freund wrote: > > I find it a little suspicious that startcreate is merrily starting > > the postmaster on port 5432, without concern for the possibility > > that that port is in use or blocked by a packet filter. > > It's a container that's just created f

Re: Regression tests failures on Windows Server 2019 - on master at commit # d816f366b

2022-03-04 Thread Tom Lane
Andres Freund writes: > On 2022-03-04 09:54:28 -0500, Tom Lane wrote: >> I find it a little suspicious that startcreate is merrily starting >> the postmaster on port 5432, without concern for the possibility >> that that port is in use or blocked by a packet filter. > It's a container that's just

Re: Regression tests failures on Windows Server 2019 - on master at commit # d816f366b

2022-03-04 Thread Andres Freund
Hi, On 2022-03-04 09:54:28 -0500, Tom Lane wrote: > Thomas Munro writes: > > https://github.com/postgres/postgres/commits/master > > > I don't see what that patch has to do with the symptoms. > > The buildfarm is not unhappy, so I'd be looking at what changed > recently in the cfbot's setup. V

Re: Regression tests failures on Windows Server 2019 - on master at commit # d816f366b

2022-03-04 Thread Tom Lane
Thomas Munro writes: > On Fri, Mar 4, 2022 at 10:37 PM Bharath Rupireddy > wrote: >> It looks like regression tests are failing on Windows Server 2019 [1]. >> Ignore if it's reported elsewhere. > It's broken since 46ab07ff "Clean up assorted failures under clang's > -fsanitize=undefined checks."

Re: Regression tests failures on Windows Server 2019 - on master at commit # d816f366b

2022-03-04 Thread Thomas Munro
On Fri, Mar 4, 2022 at 10:37 PM Bharath Rupireddy wrote: > It looks like regression tests are failing on Windows Server 2019 [1]. > Ignore if it's reported elsewhere. It's broken since 46ab07ff "Clean up assorted failures under clang's -fsanitize=undefined checks.": https://github.com/postgres/p

Regression tests failures on Windows Server 2019 - on master at commit # d816f366b

2022-03-04 Thread Bharath Rupireddy
Hi, It looks like regression tests are failing on Windows Server 2019 [1]. Ignore if it's reported elsewhere. [1] https://github.com/postgres/postgres/runs/5419324953 ❌ 00:02 test_pl [08:28:53.758] [08:28:53.758] c:\cirrus>call "C:/Program Files/Git/usr/bin/timeout.exe" -v -k60s 15m perl src/too