Re: Regression tests fail with tzdata 2024b

2024-09-17 Thread Sven Klemm
On Tue, Sep 17, 2024 at 4:15 PM Tom Lane wrote: > Wolfgang Walther writes: > > The core regression tests need to be run with a timezone that tests > > special cases in the timezone handling code. But that might not be true > > for extensions - all they want could be a stable output across major

Re: Regression tests fail with tzdata 2024b

2024-09-17 Thread Tom Lane
Wolfgang Walther writes: > The core regression tests need to be run with a timezone that tests > special cases in the timezone handling code. But that might not be true > for extensions - all they want could be a stable output across major and > minor versions of postgres and versions of tzdata

Re: Regression tests fail with tzdata 2024b

2024-09-16 Thread Wolfgang Walther
Tom Lane: I was wondering whether the timezone used by pg_regress could be made configurable. Yes, I understood that you were suggesting that. My point is that it wouldn't do you any good: you will still have to change any regression test cases that depend on behavior PST8PDT has/had that is d

Re: Regression tests fail with tzdata 2024b

2024-09-16 Thread Tom Lane
Sven Klemm writes: > On Mon, Sep 16, 2024 at 5:19 PM Tom Lane wrote: >> Configurable to what? If your test cases are dependent on the >> historical behavior of PST8PDT, you're out of luck, because that >> simply isn't available anymore (or won't be once 2024b reaches >> your platform, anyway).

Re: Regression tests fail with tzdata 2024b

2024-09-16 Thread Sven Klemm
On Mon, Sep 16, 2024 at 5:19 PM Tom Lane wrote: > Configurable to what? If your test cases are dependent on the > historical behavior of PST8PDT, you're out of luck, because that > simply isn't available anymore (or won't be once 2024b reaches > your platform, anyway). > I was wondering whether

Re: Regression tests fail with tzdata 2024b

2024-09-16 Thread Tom Lane
Sven Klemm writes: > This is an unfortunate change as this will break extensions tests using > pg_regress for testing. We run our tests against multiple minor versions > and this getting backported means our tests will fail with the next minor > pg release. Is there a workaround available to make

Re: Regression tests fail with tzdata 2024b

2024-09-16 Thread Sven Klemm
On Mon, Sep 16, 2024 at 7:09 AM Tom Lane wrote: > Wolfgang Walther writes: > > Tom Lane: > >> Also, as a real place to a greater extent > >> than "PST8PDT" is, it's more subject to historical revisionism when > >> somebody turns up evidence of local law having been different than > >> TZDB curre

Re: Regression tests fail with tzdata 2024b

2024-09-15 Thread Tom Lane
Wolfgang Walther writes: > Tom Lane: >> Also, as a real place to a greater extent >> than "PST8PDT" is, it's more subject to historical revisionism when >> somebody turns up evidence of local law having been different than >> TZDB currently thinks. > I now tried all versions of tzdata which we ha

Re: Regression tests fail with tzdata 2024b

2024-09-15 Thread Wolfgang Walther
Tom Lane: Also, as a real place to a greater extent than "PST8PDT" is, it's more subject to historical revisionism when somebody turns up evidence of local law having been different than TZDB currently thinks. I now tried all versions of tzdata which we had in tree back to 2018g, they all work

Re: Regression tests fail with tzdata 2024b

2024-09-14 Thread Tom Lane
Wolfgang Walther writes: > Building --with-system-tzdata and the latest tzdata 2024b fails the > regression tests for me (see attached .diffs). This seems to be because > of [1], which changed the way "PST8PDT" is handled. This is the timezone > that the regression tests are run with. That's q

Regression tests fail with tzdata 2024b

2024-09-14 Thread Wolfgang Walther
Building --with-system-tzdata and the latest tzdata 2024b fails the regression tests for me (see attached .diffs). This seems to be because of [1], which changed the way "PST8PDT" is handled. This is the timezone that the regression tests are run with. From 2024b on, "PST8PDT" is the same as "