Re: Regarding the order of the header file includes

On Wed, Mar 13, 2024 at 10:07 PM Peter Eisentraut wrote: > On 12.03.24 12:47, Richard Guo wrote: > > > > On Wed, Mar 6, 2024 at 5:32 PM Richard Guo > > wrote: > > > > Please note that this patch only addresses the order of header file > > includes in backen

Re: Regarding the order of the header file includes

On 12.03.24 12:47, Richard Guo wrote: On Wed, Mar 6, 2024 at 5:32 PM Richard Guo > wrote: Please note that this patch only addresses the order of header file includes in backend modules (and might not be thorough).  It is possible that other modules m

Re: Regarding the order of the header file includes

On Wed, Mar 6, 2024 at 5:32 PM Richard Guo wrote: > Please note that this patch only addresses the order of header file > includes in backend modules (and might not be thorough). It is possible > that other modules may have a similar issue, but I have not evaluated > them yet. > Attached is v2,

Re: Regarding the order of the header file includes

On Fri, Mar 8, 2024 at 6:58 PM Bharath Rupireddy < bharath.rupireddyforpostg...@gmail.com> wrote: > On Thu, Mar 7, 2024 at 12:39 PM Richard Guo > wrote: > > > > While rebasing one of my patches I noticed that the header file includes > > in relnode.c are not sorted in order. So I wrote a naive s

Re: Regarding the order of the header file includes

On Thu, Mar 7, 2024 at 12:39 PM Richard Guo wrote: > > While rebasing one of my patches I noticed that the header file includes > in relnode.c are not sorted in order. So I wrote a naive script to see > if any other C files have the same issue. The script is: > > #!/bin/bash > > find . -name "*.

Re: Regarding the order of the header file includes

On Wed, Mar 6, 2024 at 6:25 PM Bharath Rupireddy < bharath.rupireddyforpostg...@gmail.com> wrote: > On Wed, Mar 6, 2024 at 3:02 PM Richard Guo wrote: > > > > I think we generally follow the rule that we include 'postgres.h' or > > 'postgres_fe.h' first, followed by system header files, and then >

Re: Regarding the order of the header file includes

On Wed, Mar 6, 2024 at 3:02 PM Richard Guo wrote: > > I think we generally follow the rule that we include 'postgres.h' or > 'postgres_fe.h' first, followed by system header files, and then > postgres header files ordered in ASCII value. I noticed that in some C > files we fail to follow this rul

Regarding the order of the header file includes

I think we generally follow the rule that we include 'postgres.h' or 'postgres_fe.h' first, followed by system header files, and then postgres header files ordered in ASCII value. I noticed that in some C files we fail to follow this rule strictly. Attached is a patch to fix this. Back in 2019,