On Mon, Mar 11, 2024 at 4:36 PM Amit Kapila wrote:
>
> On Mon, Mar 11, 2024 at 4:17 PM shveta malik wrote:
> >
> >
> > Please find the patch attached for the same.
> >
>
> LGTM. I'll push this tomorrow unless I see any comments/objections to
> this change.
>
Pushed.
--
With Regards,
Amit Kapil
On Mon, Mar 11, 2024 at 4:17 PM shveta malik wrote:
>
> On Sat, Mar 2, 2024 at 4:44 PM Amit Kapila wrote:
> >
> > Right, I think the quoted code has check "if (!RecoveryInProgress())".
> >
> > >
> > But apart from that, your
> > > observation seems accurate, yes.
> > >
> >
> > I also find the ob
On Sat, Mar 2, 2024 at 4:44 PM Amit Kapila wrote:
>
> Right, I think the quoted code has check "if (!RecoveryInProgress())".
>
> >
> But apart from that, your
> > observation seems accurate, yes.
> >
>
> I also find the observation correct and the code has been like that
> since commit 5a991ef8 [
On Fri, Mar 1, 2024 at 4:40 PM Matthias van de Meent
wrote:
>
> On Mon, 26 Feb 2024 at 12:46, shveta malik wrote:
> >
> > Hi hackers,
> >
> > I would like to understand why we have code [1] that retrieves
> > RecentFlushPtr in WalSndWaitForWal() outside of the loop. We utilize
> > RecentFlushPtr
On Mon, 26 Feb 2024 at 12:46, shveta malik wrote:
>
> Hi hackers,
>
> I would like to understand why we have code [1] that retrieves
> RecentFlushPtr in WalSndWaitForWal() outside of the loop. We utilize
> RecentFlushPtr later within the loop, but prior to that, we already
> have [2]. Wouldn't [2]
Hi,
On Mon, Feb 26, 2024 at 05:16:39PM +0530, shveta malik wrote:
> Hi hackers,
>
> I would like to understand why we have code [1] that retrieves
> RecentFlushPtr in WalSndWaitForWal() outside of the loop. We utilize
> RecentFlushPtr later within the loop, but prior to that, we already
> have [2
Hi hackers,
I would like to understand why we have code [1] that retrieves
RecentFlushPtr in WalSndWaitForWal() outside of the loop. We utilize
RecentFlushPtr later within the loop, but prior to that, we already
have [2]. Wouldn't [2] alone be sufficient?
Just to check the impact, I ran 'make che
