On Wed, Mar 31, 2021 at 10:43:00AM +0900, Michael Paquier wrote:
> Jacob has just raised this as an issue for an integration with NLS,
> because it may be possible that things fail with "SSL error" but a
> different error pattern, causing false positives:
> https://www.postgresql.org/message-id/e0f
On Tue, Mar 30, 2021 at 12:15:07PM -0300, Alvaro Herrera wrote:
> The only complain I have is that "the given node" is nonsensical in
> PostgresNode. I suggest to delete the word "given". Also "This is
> expected to fail with a message that matches the regular expression
> $expected_stderr".
You
On Tue, Mar 30, 2021 at 07:14:55PM -0300, Alvaro Herrera wrote:
> On 2021-Mar-30, Daniel Gustafsson wrote:
>> This double concatenation could be a single concat, or just use scalar value
>> interpolation in the string to make it even more readable. As it isn't using
>> the same line broken pattern
On 2021-Mar-30, Daniel Gustafsson wrote:
> +$node->connect_ok($common_connstr . " " . "user=ssltestuser",
>
> This double concatenation could be a single concat, or just use scalar value
> interpolation in the string to make it even more readable. As it isn't using
> the same line broken pattern
> On 30 Mar 2021, at 11:53, Michael Paquier wrote:
>
> On Tue, Mar 30, 2021 at 03:50:28PM +0900, Michael Paquier wrote:
>> The test_*() ones are just wrappers for psql able to use a customized
>> connection string. It seems to me that it would make sense to move
>> those two into PostgresNode::p
On 2021-Mar-30, Michael Paquier wrote:
> On Tue, Mar 30, 2021 at 03:50:28PM +0900, Michael Paquier wrote:
> > The test_*() ones are just wrappers for psql able to use a customized
> > connection string. It seems to me that it would make sense to move
> > those two into PostgresNode::psql itself a
On 3/30/21 5:53 AM, Michael Paquier wrote:
> On Tue, Mar 30, 2021 at 03:50:28PM +0900, Michael Paquier wrote:
>> The test_*() ones are just wrappers for psql able to use a customized
>> connection string. It seems to me that it would make sense to move
>> those two into PostgresNode::psql itself
On Tue, Mar 30, 2021 at 03:50:28PM +0900, Michael Paquier wrote:
> The test_*() ones are just wrappers for psql able to use a customized
> connection string. It seems to me that it would make sense to move
> those two into PostgresNode::psql itself and extend it to be able to
> handle custom conne
On Thu, Mar 25, 2021 at 09:25:11AM -0400, Andrew Dunstan wrote:
> The thing is that SSLServer isn't currently constructed in an OO
> fashion. Typically, OO modules in perl don't export anything, and all
> access is via the class (for the constructor or static methods) or
> instances, as in
>
>
On 3/24/21 7:49 PM, Daniel Gustafsson wrote:
>> On 25 Mar 2021, at 00:26, Alvaro Herrera wrote:
>>
>> On 2021-Mar-25, Daniel Gustafsson wrote:
>>
>>> Attached is a v2 which addresses the comments raised on the main NSS
>>> thread, as
>>> well as introduces named parameters for the server cert f
> On 25 Mar 2021, at 00:26, Alvaro Herrera wrote:
>
> On 2021-Mar-25, Daniel Gustafsson wrote:
>
>> Attached is a v2 which addresses the comments raised on the main NSS thread,
>> as
>> well as introduces named parameters for the server cert function to make the
>> test code easier to read.
>
On 2021-Mar-25, Daniel Gustafsson wrote:
> Attached is a v2 which addresses the comments raised on the main NSS thread,
> as
> well as introduces named parameters for the server cert function to make the
> test code easier to read.
I don't like this patch. I think your SSL::Server::OpenSSL and
Attached is a v2 which addresses the comments raised on the main NSS thread, as
well as introduces named parameters for the server cert function to make the
test code easier to read.
--
Daniel Gustafsson https://vmware.com/
v2-0001-Refactor-SSL-testharness-for-multiple-library.pat
In an attempt to slice off as much non-NSS specific changes as possible from
the larger libnss patch proposed in [0], the attached patch contains the ssl
test harness refactoring to support multiple TLS libraries.
The changes are mostly a refactoring to hide library specific setup in their
own mod
14 matches
Mail list logo
