Re: Refactor CheckpointWriteDelay()

2022-02-19 Thread Andres Freund
Hi, On 2022-02-10 17:31:55 +0530, Bharath Rupireddy wrote: > Secondly, remove the function ImmediateCheckpointRequested() and read > the ckpt_flags from the CheckpointerShmem with volatile qualifier. > This saves some LOC and cost = dirty buffers written to disk * one > function call cost. The co

Re: Refactor CheckpointWriteDelay()

2022-02-15 Thread Nitin Jadhav
> Given that CheckpointWriteDelay() is really a hot code path i.e. gets > called for every dirty buffer written to disk, here's an opportunity > for us to improve it by avoiding some function calls. I have reviewed the patch and I agree that the patch improves the code. > Firstly, the AmCheckpoin

Refactor CheckpointWriteDelay()

2022-02-10 Thread Bharath Rupireddy
:00 2001 From: Bharath Rupireddy Date: Tue, 8 Feb 2022 05:19:37 + Subject: [PATCH v1] Refactor CheckpointWriteDelay() --- src/backend/postmaster/checkpointer.c | 36 +++ src/backend/storage/buffer/bufmgr.c | 6 +++-- 2 files changed, 13 insertions(+), 29 deletions(-