Re: Redundant errdetail prefix "The error was:" in some logical replication messages

2021-03-31 Thread Tom Lane
Peter Smith writes: > PSA version 2 of this patch which adopts your suggestions. LGTM, pushed. regards, tom lane

Re: Redundant errdetail prefix "The error was:" in some logical replication messages

2021-03-30 Thread Peter Smith
On Tue, Mar 30, 2021 at 5:10 PM Tom Lane wrote: > > Peter Smith writes: > > There are a couple of error messages within the logical replication > > code where the errdetail text includes a prefix of "The error was:" > > Hmm, isn't project style more usually to include the error reason > in the pr

Re: Redundant errdetail prefix "The error was:" in some logical replication messages

2021-03-29 Thread Bharath Rupireddy
On Tue, Mar 30, 2021 at 11:40 AM Tom Lane wrote: > > Peter Smith writes: > > There are a couple of error messages within the logical replication > > code where the errdetail text includes a prefix of "The error was:" > > Hmm, isn't project style more usually to include the error reason > in the p

Re: Redundant errdetail prefix "The error was:" in some logical replication messages

2021-03-29 Thread Tom Lane
Peter Smith writes: > There are a couple of error messages within the logical replication > code where the errdetail text includes a prefix of "The error was:" Hmm, isn't project style more usually to include the error reason in the primary message? That is, ereport(LOG, -

Redundant errdetail prefix "The error was:" in some logical replication messages

2021-03-29 Thread Peter Smith
There are a couple of error messages within the logical replication code where the errdetail text includes a prefix of "The error was:" I could not find any other examples in all the PG src which have a similar errdetail prefix like this. The text seems not only redundant, but "The error was: ERR