Peter Smith writes:
> PSA version 2 of this patch which adopts your suggestions.
LGTM, pushed.
regards, tom lane
On Tue, Mar 30, 2021 at 5:10 PM Tom Lane wrote:
>
> Peter Smith writes:
> > There are a couple of error messages within the logical replication
> > code where the errdetail text includes a prefix of "The error was:"
>
> Hmm, isn't project style more usually to include the error reason
> in the pr
On Tue, Mar 30, 2021 at 11:40 AM Tom Lane wrote:
>
> Peter Smith writes:
> > There are a couple of error messages within the logical replication
> > code where the errdetail text includes a prefix of "The error was:"
>
> Hmm, isn't project style more usually to include the error reason
> in the p
Peter Smith writes:
> There are a couple of error messages within the logical replication
> code where the errdetail text includes a prefix of "The error was:"
Hmm, isn't project style more usually to include the error reason
in the primary message? That is,
ereport(LOG,
-
There are a couple of error messages within the logical replication
code where the errdetail text includes a prefix of "The error was:"
I could not find any other examples in all the PG src which have a
similar errdetail prefix like this.
The text seems not only redundant, but "The error was: ERR