Re: Reducing the maintenance overhead of test_oat_hooks

2022-07-31 Thread Alvaro Herrera
On 2022-Jul-30, Tom Lane wrote: > I do not > think that test_oat_hooks.c has any business imposing > an extra maintenance burden on us all, so I propose > nuking nodetag_to_string() from orbit, as attached. +1 -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/

Reducing the maintenance overhead of test_oat_hooks

2022-07-30 Thread Tom Lane
I've been annoyed several times lately by having to update the list of node types embodied in test_oat_hooks.c's nodetag_to_string(). I got around to looking at that more closely, and realized that it is only used for utility statements, which (a) are a very small subset of the node types that tha