Re: Re[2]: [PATCH] allow pg_current_logfile() execution under pg_monitor role

2024-02-14 Thread Nathan Bossart
On Wed, Feb 14, 2024 at 01:45:31PM -0500, Tom Lane wrote: > "Pavlo Golub" writes: >> Oh, thanks! I forgot, indeed, to update docs and catalog version! My >> bad! > > Docs, yes, but don't include catversion bumps in submitted patches. > They'll just lead to merge problems when somebody else chang

Re: Re[2]: [PATCH] allow pg_current_logfile() execution under pg_monitor role

2024-02-14 Thread Pavlo Golub
On Wed, Feb 14, 2024, 19:45 Tom Lane wrote: > "Pavlo Golub" writes: > > Oh, thanks! I forgot, indeed, to update docs and catalog version! My > > bad! > > Docs, yes, but don't include catversion bumps in submitted patches. > They'll just lead to merge problems when somebody else changes the > cur

Re: Re[2]: [PATCH] allow pg_current_logfile() execution under pg_monitor role

2024-02-14 Thread Tom Lane
"Pavlo Golub" writes: > Oh, thanks! I forgot, indeed, to update docs and catalog version! My > bad! Docs, yes, but don't include catversion bumps in submitted patches. They'll just lead to merge problems when somebody else changes the current catversion. We rely on the committer to remember to

Re[2]: [PATCH] allow pg_current_logfile() execution under pg_monitor role

2024-02-14 Thread Pavlo Golub
On Mon, Feb 12, 2024 at 09:49:45AM -0600, Nathan Bossart wrote: Okay. I'll plan on committing this in the next few days. Here is what I have staged for commit. Oh, thanks! I forgot, indeed, to update docs and catalog version! My bad! In my defense, I was trying to find tests but I misse

Re[2]: [PATCH] allow pg_current_logfile() execution under pg_monitor role

2024-02-12 Thread Pavlo Golub
Are there any other functions that pg_monitor ought to have privileges for? Not that I'm aware of at the moment. This one was found by chance. Kind regards, Pavlo Golub