On 17.06.25 20:50, Dean Rasheed wrote:
On Tue, 17 Jun 2025 at 13:56, jian he wrote:
On Tue, Jun 17, 2025 at 7:42 PM Peter Eisentraut wrote:
However, I see your point that it contrasts with the attidentity code
just above.
Perhaps a way to resolve this would be to rewrite the comment someth
On Tue, 17 Jun 2025 at 13:56, jian he wrote:
>
> On Tue, Jun 17, 2025 at 7:42 PM Peter Eisentraut wrote:
> >
> > However, I see your point that it contrasts with the attidentity code
> > just above.
> >
> > Perhaps a way to resolve this would be to rewrite the comment something
> > like:
> >
> >
On Tue, Jun 17, 2025 at 7:42 PM Peter Eisentraut wrote:
>
> However, I see your point that it contrasts with the attidentity code
> just above.
>
> Perhaps a way to resolve this would be to rewrite the comment something
> like:
>
> /*
> * Although inserting into a GENERATED BY DEFAULT i
On 17.06.25 11:31, Dean Rasheed wrote:
On Tue, 17 Jun 2025 at 06:27, Peter Eisentraut wrote:
Jian is right, there are no OVERRIDING clauses for generated columns,
and the shown code also doesn't check for them, so the comment doesn't
match the code. I suspect that commit 17958972fe3b slightly
On Tue, 17 Jun 2025 at 06:27, Peter Eisentraut wrote:
>
> On 10.04.25 11:46, Amit Langote wrote:
> >
> > On Thu, Apr 10, 2025 at 5:58 PM jian he wrote:
> >>
> >> in function, rewriteTargetListIU we have:
> >>
> >> /*
> >> * Can only insert DEFAULT into generated columns
On 10.04.25 11:46, Amit Langote wrote:
Hi,
On Thu, Apr 10, 2025 at 5:58 PM jian he wrote:
hi.
in function, rewriteTargetListIU
we have:
for (attrno = 1; attrno <= numattrs; attrno++)
{
/*
* Can only insert DEFAULT into generated columns, regardless of
Hi,
On Thu, Apr 10, 2025 at 5:58 PM jian he wrote:
>
> hi.
>
> in function, rewriteTargetListIU
> we have:
>
> for (attrno = 1; attrno <= numattrs; attrno++)
> {
> /*
> * Can only insert DEFAULT into generated columns, regardless of
> * any OVERRIDING clauses
