Re: windows build slow due to windows.h includes

2021-09-23 Thread Michael Paquier
On Wed, Sep 22, 2021 at 02:14:59PM +0530, Amit Kapila wrote: > On Wed, Sep 22, 2021 at 11:14 AM Noah Misch wrote: > > +1, great win for a one-liner. > > +1. It reduced the build time of Postgres from "Time Elapsed > 00:01:57.60" to "Time Elapsed 00:01:38.11" in my Windows env. (Win 10, > MSVC 201

Re: windows build slow due to windows.h includes

2021-09-22 Thread Amit Kapila
On Wed, Sep 22, 2021 at 11:14 AM Noah Misch wrote: > > On Tue, Sep 21, 2021 at 12:30:35PM -0700, Andres Freund wrote: > > solution to windows.h being just so damn big, the delightfully named > > WIN32_LEAN_AND_MEAN. > > > > This reduces the non-incremental buildtime in my 8 core windows VM from >

Re: windows build slow due to windows.h includes

2021-09-22 Thread Juan José Santamaría Flecha
On Wed, Sep 22, 2021 at 1:56 AM Andres Freund wrote: > On 2021-09-21 20:26:36 -0300, Ranier Vilela wrote: > > Em ter., 21 de set. de 2021 às 16:30, Andres Freund > > escreveu: > > > But that's too much work for my taste. As it turns out there's a > partial > > > solution to windows.h being just

Re: windows build slow due to windows.h includes

2021-09-21 Thread Noah Misch
On Tue, Sep 21, 2021 at 12:30:35PM -0700, Andres Freund wrote: > solution to windows.h being just so damn big, the delightfully named > WIN32_LEAN_AND_MEAN. > > This reduces the non-incremental buildtime in my 8 core windows VM from 187s > to > 140s. Cross compiling from linux it's > master: > re

Re: windows build slow due to windows.h includes

2021-09-21 Thread Andres Freund
Hi, On 2021-09-21 20:26:36 -0300, Ranier Vilela wrote: > Em ter., 21 de set. de 2021 às 16:30, Andres Freund > escreveu: > > But that's too much work for my taste. As it turns out there's a partial > > solution to windows.h being just so damn big, the delightfully named > > WIN32_LEAN_AND_MEAN. >

Re: windows build slow due to windows.h includes

2021-09-21 Thread Ranier Vilela
Em ter., 21 de set. de 2021 às 16:30, Andres Freund escreveu: > Hi, > > For the AIO stuff I needed to build postgres for windows. And I was a bit > horrified by the long compile times. At first I was ready to blame the MS > compiler for being slow, until I noticed that using mingw gcc from linux

Re: windows build slow due to windows.h includes

2021-09-21 Thread Andres Freund
Hi, On 2021-09-21 16:13:55 -0400, Andrew Dunstan wrote: > I also see references to VC_EXTRALEAN which defines this and some other > stuff that might make things even faster. I don't think that's relevant to "us", just mfc apps (which we gladly aren't). From what I can see we'd have to actually cl

Re: windows build slow due to windows.h includes

2021-09-21 Thread Andrew Dunstan
On 9/21/21 3:30 PM, Andres Freund wrote: > Hi, > > For the AIO stuff I needed to build postgres for windows. And I was a bit > horrified by the long compile times. At first I was ready to blame the MS > compiler for being slow, until I noticed that using mingw gcc from linux to > cross compile to