On Wed, Sep 26, 2018 at 10:34 AM Michael Paquier wrote:
>
> On Tue, Sep 25, 2018 at 11:54:53PM +0900, Masahiko Sawada wrote:
> > Can we use "XLOG_PARAMETER_CHANGE record" instead of "record
> > XLOG_PARAMETER_CHANGE" at the second hunk because the comment of the
> > first hunk uses it. The other
On Tue, Sep 25, 2018 at 11:54:53PM +0900, Masahiko Sawada wrote:
> Can we use "XLOG_PARAMETER_CHANGE record" instead of "record
> XLOG_PARAMETER_CHANGE" at the second hunk because the comment of the
> first hunk uses it. The other part of this patch looks good to me.
Let's use your suggestion, an
On Tue, Sep 25, 2018 at 1:43 PM, Michael Paquier wrote:
> Sawada-san,
>
> On Mon, Sep 24, 2018 at 08:28:45AM +0900, Michael Paquier wrote:
>> Wouldn't it be better to incorporate the new test as part of
>> 004_restart.pl? This way, we avoid initializing a full instance, which
>> is always a good
Sawada-san,
On Mon, Sep 24, 2018 at 08:28:45AM +0900, Michael Paquier wrote:
> Wouldn't it be better to incorporate the new test as part of
> 004_restart.pl? This way, we avoid initializing a full instance, which
> is always a good thing as that's very costly. The top of this file also
> mention
On Thu, Sep 20, 2018 at 09:51:34PM +0900, Masahiko Sawada wrote:
> I agreed with your all review comments. Attached the updated patch.
Wouldn't it be better to incorporate the new test as part of
004_restart.pl? This way, we avoid initializing a full instance, which
is always a good thing as that
On Wed, Sep 19, 2018 at 12:12 PM, Kyotaro HORIGUCHI
wrote:
> At Sat, 15 Sep 2018 19:26:39 +0900, Masahiko Sawada
> wrote in
>> >> To fix that maybe we can disable commitTs if
>> >> controlFile->track_commit_timestamp == false and the
>> >> track_commit_timestamp == true even in crash recovery.
On Wed, Sep 19, 2018 at 12:12:44PM +0900, Kyotaro HORIGUCHI wrote:
> The fix looks good to me. The TAP test works fine.
>
> In the TAP test:
>
>
> The test script lacks a general description about its objective.
That's always welcome. The patch looks sensible to me.
> The following error
At Sat, 15 Sep 2018 19:26:39 +0900, Masahiko Sawada
wrote in
> >> To fix that maybe we can disable commitTs if
> >> controlFile->track_commit_timestamp == false and the
> >> track_commit_timestamp == true even in crash recovery.
> >
> > Hmm, so keep it off while crash recovery runs, and once it'
On Sat, Sep 15, 2018 at 12:29 AM, Alvaro Herrera
wrote:
> On 2018-Sep-15, Masahiko Sawada wrote:
>
>> On Fri, Sep 14, 2018 at 4:27 PM, 李海龙 wrote:
>
>> > When I enable the parameter track_commit_timestamp in postgresql.conf of a
>> > Base Backup (making a Base Backup from a standby and the
>> > tr
On 2018-Sep-15, Masahiko Sawada wrote:
> On Fri, Sep 14, 2018 at 4:27 PM, 李海龙 wrote:
> > When I enable the parameter track_commit_timestamp in postgresql.conf of a
> > Base Backup (making a Base Backup from a standby and the
> > track_commit_timestamp is off on it),
>
> In addition to the above
On Fri, Sep 14, 2018 at 4:27 PM, 李海龙 wrote:
>
> HI, Dear pgsql-hackers
>
>
> The details are as follows:
>
>
> Environment:
>
> OS:CentOS 6.7 (Final), Linux 3.18.48-11.el6.x86_64 x86_64, 64-bit
>
>
> PostgreSQL:
>
> postgres=# select version();
>
11 matches
Mail list logo
